[Smart hashing] Cleanup #2875
Closed
[Smart hashing] Cleanup #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the smart hashing implementation by removing unused destination slugs, feature flags, and the legacy smart hashing module from Actions Core. The changes involve updating all hash function calls across multiple destinations to remove the now-unnecessary features parameters and related context.
Reviewed Changes
Copilot reviewed 77 out of 77 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| facebook-conversions-api/pageView2/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/pageView/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/initiateCheckout2/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/initiateCheckout/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/fb-capi-user-data.ts | Updated processHashing calls to remove features and context. |
| facebook-conversions-api/custom2/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/custom/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/addToCart2/index.ts | Removed features parameter from hash_user_data call. |
| facebook-conversions-api/addToCart/index.ts | Removed features parameter from hash_user_data call. |
| dynamic-yield-audiences/* | Removed features parameter from various hashing and audience functions. |
| delivrai-activate/* | Removed features parameter from updateSegment and related functions. |
| amazon-amc/* | Removed features parameter from hashing functions and adjusted tests accordingly. |
| core/hashing-utils.ts & tests/hashing-utils.test.ts | Removed; these legacy modules are no longer needed. |
Comments suppressed due to low confidence (2)
packages/destination-actions/src/destinations/facebook-conversions-api/fb-capi-user-data.ts:200
- Ensure that the removal of the features parameter and associated context values does not alter the expected hashing behavior. Verify that unit tests cover all edge cases for the updated hash implementations.
return processHashing(value, 'sha256', 'hex')
packages/destination-actions/src/destinations/amazon-amc/function.ts:15
- Ensure that the removal of the features parameter from hashedPayload calls in payload transformations maintains the integrity of the hashed values. Confirm that test coverage is sufficient to validate this behavior.
const payloadRecord = createPayloadToUploadRecords(payload, audienceSettings)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 77.93% 78.78% +0.84%
==========================================
Files 1047 1099 +52
Lines 19246 21935 +2689
Branches 3751 4417 +666
==========================================
+ Hits 14999 17281 +2282
- Misses 2925 3391 +466
+ Partials 1322 1263 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+25
to
+36
| // const slugsToBypassFeatureFlag = [ | ||
| // 'actions-facebook-custom-audiences', | ||
| // 'actions-linkedin-audiences', | ||
| // 'actions-snap-audiences', | ||
| // 'actions-snap-conversions', | ||
| // 'actions-tiktok-offline-conversions', | ||
| // 'tiktok-conversions', | ||
| // 'actions-google-enhanced-conversions', | ||
| // 'actions-google-campaign-manager-360', | ||
| // 'actions-facebook-conversions-api', | ||
| // 'actions-tiktok-audiences' | ||
| // ] |
There was a problem hiding this comment.
Should this be deleted?
| return processHashing(value, 'sha256', 'hex', cleaningFunction) | ||
| } | ||
|
|
||
| export function hashValue(value: string, cleaningFunction?: (value: string) => string): string { |
There was a problem hiding this comment.
Is this function needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes cleanup related to smart hashing:
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.