slvs: support getting the list of bad constraints in the sketch solving API #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally removed it in commit 7ceb7fa, and this broke the WASM library because Slvs_Entity contains two such arrays.
This was only available in the system solving API until now, and that made the sketch solving API less usable, even though it's the only API available through the Cython and Emscripten bindings. In this initial implementation there's a redundant allocation and copy of the bad constraint list, but it was done this way in order to make a minimal change that would be the most ergonomic to use from both the C interface as well as the FFI binding interfaces.
|
@vespakoen @phkahler it seems this holds up hlorus/CAD_Sketcher#504 |
|
@vespakoen @phkahler ping. |
|
Looks OK and I can appreciate making things easier for CAD sketcher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was only available in the system solving API until now, and that made the sketch solving API less usable, even though it's the only API available through the Cython and Emscripten bindings.
In this initial implementation there's a redundant allocation and copy of the bad constraint list, but it was done this way in order to make a minimal change that would be the most ergonomic to use from both the C interface as well as the FFI binding interfaces.
Fixes #1546