Skip to content

Commit 83b7d04

Browse files
author
Jim Lindblom
committed
fixed some comments, re-worked pin labels in sch.
Fixed comments in System_Functions.ino which mapped Arduino pins to display pins Some labels on the schematic did not match the display pin they connected to. Renamed those nets to make more sense. Added a pdf of current schematic, not sure if this'll be sustainable. Trying it out. Defaulted display type to S7S in the firmware.
1 parent 8a794f2 commit 83b7d04

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

firmware/Serial 7-Segment Display/Serial_7_Segment_Display_Firmware/Serial_7_Segment_Display_Firmware.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ SevSeg myDisplay; //Create an instance of the object
3535
//OpenSegment uses PNP and NPN transistors to drive larger displays
3636
#define S7S 1
3737
#define OPENSEGMENT 2
38-
#define DISPLAY_TYPE OPENSEGMENT
38+
#define DISPLAY_TYPE S7S
3939

4040
//Global variables
4141
unsigned int analogValue6 = 0; //These are used in analog meter mode

firmware/Serial 7-Segment Display/Serial_7_Segment_Display_Firmware/System_Functions.ino

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -144,25 +144,25 @@ void setupDisplay()
144144
//This pinout is for the original Serial7Segment layout
145145
//-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
146146
#if DISPLAY_TYPE == S7S
147-
int digit1 = 16; //Analog 2 is 16
148-
int digit2 = 17; //A3 is 17
149-
int digit3 = 3;
150-
int digit4 = 4;
147+
int digit1 = 16; // DIG1 = A2/16 (PC2)
148+
int digit2 = 17; // DIG2 = A3/17 (PC3)
149+
int digit3 = 3; // DIG3 = D3 (PD3)
150+
int digit4 = 4; // DIG4 = D4 (PD4)
151151

152152
//Declare what pins are connected to the segments
153-
int segA = 8; //Labeled B on schematic
154-
int segB = 14; //Labeled C on schematic
155-
int segC = 6; //Labeled A/COL on schematic
156-
int segD = A1;
157-
int segE = 23; //This is not a standard Arduino pin: Must add PB7 as digital pin 23 to pins_arduino.h
158-
int segF = 7;
159-
int segG = 5; //Labeled G/APOS on schematic
160-
int segDP= 22; //This is not a standard Arduino pin: Must add PB6 as digital pin 22 to pins_arduino.h
161-
162-
int digitColon = 2; //The digit is the top side of this LED
163-
int segmentColon = 6; //The segment is the bottom side of this LED
164-
int digitApostrophe = 9;
165-
int segmentApostrophe = 7; //Labeled F on schematic (there is an incorrect label G/APOS)
153+
int segA = 8; // A = D8 (PB0)
154+
int segB = 14; // B = A0 (PC0)
155+
int segC = 6; // C = D6 (PD6), shares a pin with colon cathode
156+
int segD = A1; // D = A1 (PC1)
157+
int segE = 23; // E = PB7 (not a standard Arduino pin: Must add PB7 as digital pin 23 to pins_arduino.h)
158+
int segF = 7; // F = D7 (PD6), shares a pin with apostrophe cathode
159+
int segG = 5; // G = D5 (PD5)
160+
int segDP= 22; //DP = PB6 (not a standard Arduino pin: Must add PB6 as digital pin 22 to pins_arduino.h)
161+
162+
int digitColon = 2; // COL-A = D2 (PD2) (anode of colon)
163+
int segmentColon = 6; // COL-C = D6 (PD6) (cathode of colon), shares a pin with C
164+
int digitApostrophe = 9; // APOS-A = D9 (PB1) (anode of apostrophe)
165+
int segmentApostrophe = 7; // APOS-C = D7 (PD7) (cathode of apostrophe), shares a pin with F
166166

167167
int numberOfDigits = 4; //Do you have a 2 or 4 digit display?
168168

hardware/Serial-7-Segment-Display.brd

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<!DOCTYPE eagle SYSTEM "eagle.dtd">
3-
<eagle version="6.1">
3+
<eagle version="6.4">
44
<drawing>
55
<settings>
66
<setting alwaysvectorfont="no"/>
@@ -893,7 +893,7 @@ We've spent an enormous amount of time creating and checking these footprints an
893893
<class number="0" name="default" width="0" drill="0">
894894
</class>
895895
</classes>
896-
<designrules>
896+
<designrules name="default">
897897
<description language="en">&lt;b&gt;EAGLE Design Rules&lt;/b&gt;
898898
&lt;p&gt;
899899
The default Design Rules have been set to cover
@@ -1465,15 +1465,15 @@ design rules under a new name.</description>
14651465
<wire x1="5.842" y1="4.826" x2="7.747" y2="4.826" width="0.254" layer="1"/>
14661466
<wire x1="9.017" y1="3.556" x2="7.747" y2="4.826" width="0.254" layer="1"/>
14671467
</signal>
1468-
<signal name="G/APOS">
1468+
<signal name="G">
14691469
<contactref element="R9" pad="2"/>
14701470
<contactref element="ATMEGA328P-AU" pad="9"/>
14711471
<wire x1="24.75" y1="14.605" x2="24.75" y2="14.209" width="0.254" layer="1"/>
14721472
<wire x1="24.75" y1="14.209" x2="23.495" y2="12.954" width="0.254" layer="1"/>
14731473
<wire x1="23.495" y1="12.954" x2="13.1038" y2="12.954" width="0.254" layer="1"/>
14741474
<wire x1="12.635225" y1="12.485425" x2="13.1038" y2="12.954" width="0.254" layer="1"/>
14751475
</signal>
1476-
<signal name="F">
1476+
<signal name="F/APOS">
14771477
<contactref element="R8" pad="2"/>
14781478
<contactref element="ATMEGA328P-AU" pad="11"/>
14791479
<wire x1="14.59" y1="14.605" x2="12.49205625" y2="14.605" width="0.254" layer="1"/>
@@ -1503,7 +1503,7 @@ design rules under a new name.</description>
15031503
<wire x1="7.62" y1="5.08" x2="1.905" y2="10.795" width="0.254" layer="16"/>
15041504
<wire x1="1.905" y1="11.176" x2="1.905" y2="10.795" width="0.254" layer="16"/>
15051505
</signal>
1506-
<signal name="C">
1506+
<signal name="B">
15071507
<contactref element="R4" pad="2"/>
15081508
<contactref element="ATMEGA328P-AU" pad="23"/>
15091509
<via x="4.156571875" y="11.303" extent="1-16" drill="0.508"/>
@@ -1519,7 +1519,7 @@ design rules under a new name.</description>
15191519
<wire x1="28.067" y1="14.605" x2="27.3304" y2="13.8684" width="0.254" layer="1"/>
15201520
<wire x1="4.156571875" y1="12.065" x2="4.156571875" y2="11.303" width="0.254" layer="1"/>
15211521
</signal>
1522-
<signal name="B">
1522+
<signal name="A">
15231523
<contactref element="R3" pad="2"/>
15241524
<contactref element="ATMEGA328P-AU" pad="12"/>
15251525
<via x="20.828" y="13.843" extent="1-16" drill="0.508"/>
@@ -1530,7 +1530,7 @@ design rules under a new name.</description>
15301530
<wire x1="9.9314" y1="13.1757125" x2="10.5986875" y2="13.843" width="0.254" layer="16"/>
15311531
<wire x1="10.5986875" y1="13.843" x2="20.828" y2="13.843" width="0.254" layer="16"/>
15321532
</signal>
1533-
<signal name="A/COL">
1533+
<signal name="C/COL">
15341534
<contactref element="R2" pad="2"/>
15351535
<contactref element="ATMEGA328P-AU" pad="10"/>
15361536
<wire x1="18.4" y1="14.605" x2="17.399" y2="14.605" width="0.254" layer="1"/>

hardware/Serial-7-Segment-Display.pdf

40.9 KB
Binary file not shown.

hardware/Serial-7-Segment-Display.sch

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<!DOCTYPE eagle SYSTEM "eagle.dtd">
3-
<eagle version="6.1">
3+
<eagle version="6.4">
44
<drawing>
55
<settings>
66
<setting alwaysvectorfont="no"/>
@@ -8528,7 +8528,7 @@ We've spent an enormous amount of time creating and checking these footprints an
85288528
<label x="208.28" y="106.68" size="1.27" layer="95" xref="yes"/>
85298529
</segment>
85308530
</net>
8531-
<net name="G/APOS" class="0">
8531+
<net name="G" class="0">
85328532
<segment>
85338533
<pinref part="R9" gate="G$1" pin="2"/>
85348534
<wire x1="99.06" y1="78.74" x2="101.6" y2="78.74" width="0.1524" layer="91"/>
@@ -8540,7 +8540,7 @@ We've spent an enormous amount of time creating and checking these footprints an
85408540
<label x="208.28" y="76.2" size="1.27" layer="95" xref="yes"/>
85418541
</segment>
85428542
</net>
8543-
<net name="F" class="0">
8543+
<net name="F/APOS" class="0">
85448544
<segment>
85458545
<pinref part="R8" gate="G$1" pin="2"/>
85468546
<wire x1="99.06" y1="83.82" x2="101.6" y2="83.82" width="0.1524" layer="91"/>
@@ -8576,7 +8576,7 @@ We've spent an enormous amount of time creating and checking these footprints an
85768576
<label x="208.28" y="109.22" size="1.27" layer="95" xref="yes"/>
85778577
</segment>
85788578
</net>
8579-
<net name="C" class="0">
8579+
<net name="B" class="0">
85808580
<segment>
85818581
<pinref part="R4" gate="G$1" pin="2"/>
85828582
<wire x1="99.06" y1="99.06" x2="101.6" y2="99.06" width="0.1524" layer="91"/>
@@ -8588,7 +8588,7 @@ We've spent an enormous amount of time creating and checking these footprints an
85888588
<label x="208.28" y="111.76" size="1.27" layer="95" xref="yes"/>
85898589
</segment>
85908590
</net>
8591-
<net name="B" class="0">
8591+
<net name="A" class="0">
85928592
<segment>
85938593
<pinref part="R3" gate="G$1" pin="2"/>
85948594
<wire x1="99.06" y1="104.14" x2="101.6" y2="104.14" width="0.1524" layer="91"/>
@@ -8600,7 +8600,7 @@ We've spent an enormous amount of time creating and checking these footprints an
86008600
<label x="208.28" y="66.04" size="1.27" layer="95" xref="yes"/>
86018601
</segment>
86028602
</net>
8603-
<net name="A/COL" class="0">
8603+
<net name="C/COL" class="0">
86048604
<segment>
86058605
<pinref part="R2" gate="G$1" pin="2"/>
86068606
<wire x1="99.06" y1="109.22" x2="101.6" y2="109.22" width="0.1524" layer="91"/>

0 commit comments

Comments
 (0)