guide_axis_theta: fix missing label for one unique key #6424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
reviewed
Apr 14, 2025
tests/testthat/test-guide-axis.R
Outdated
Comment on lines
385
to
392
| test_that("guide_axis_theta with only one axis key", { | ||
| p <- ggplot(data.frame(x = "a", y = 1:3), aes(x, y)) + | ||
| geom_point() + | ||
| coord_radial(start = 0, end = pi / 2, inner.radius = 0.5) + | ||
| guides(theta = guide_axis_theta(angle = 0)) | ||
| expect_doppelganger("guide_axis_theta with only one axis key", p) | ||
| }) | ||
|
|
There was a problem hiding this comment.
I don't think this needs a visual snapshot, we can get_guide_data(p, "theta") to test the representation of the guide. The rest of the plot can also be simplified by leaving out the guides() and the arguments to coord_radial().
|
Thanks for the clarification—I've simplified the test accordingly. |
teunbrand
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6423
I don't understand why the
vdifftest gives different results when I run the same code interactively."