-
Notifications
You must be signed in to change notification settings - Fork 45.8k
feat(platform/library): Triggered-agent support #10167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(platform/library): Triggered-agent support #10167
Conversation
…ion-for-webhook-triggered
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
Here's the code health analysis summary for commits Analysis Summary
|
Thank you for your PR implementing webhook-triggered agent support. The code changes look good, but since this is marked as WIP, there are a few things to address before it can be merged:
Your code changes look solid - I especially appreciate how you've maintained the user_id checks in the webhook-related functions and updated the database schema appropriately. Once you've completed the PR description and checklist, this should be ready for further review. |
Thank you for your work on adding webhook-triggered agent support to the platform. Since this is marked as a Work in Progress (WIP), I understand it's not yet ready for full review, but here are some points to address before this can be merged:
The changes look promising and address an important feature, but they need more documentation and testing before they can be merged. Please update the PR with these items when you're ready for a more thorough review. |
2118ef3
to
3781a07
Compare
Thank you for your PR working on webhook-triggered agent support! I see this is marked as a Work in Progress (WIP), which explains the current state of the PR. Before this can be merged, you'll need to address the following:
Please update the PR when it's no longer a work in progress and all these items have been addressed. Looking forward to seeing the completed implementation! |
Thank you for your PR on webhook-triggered agent support! I notice this is marked as WIP, but there are a few things that need attention before this can be merged:
When you're ready to move this PR out of WIP status, please update the description with these details and complete the checklist. This will help reviewers understand the purpose and impact of your changes. |
Thank you for your PR adding webhook-triggered agent support! I notice this is marked as a Work in Progress, so here's some feedback to help guide you toward completion:
Please update your PR when it's ready for review, completing the description and checklist. Feel free to remove the WIP marker at that point. |
Thank you for your PR on adding Webhook-triggered Agent support. Since this is marked as a work in progress (WIP), I'm providing initial feedback before you finalize it:
Please update the PR when it's no longer a work in progress and ready for a thorough review. Looking forward to seeing the completed implementation. |
f9d0a80
to
9f0ee89
Compare
Thank you for your PR implementing webhook-triggered agent support. Since this is marked as a Work in Progress (WIP), I understand it's not ready for final review yet. Here's what you'll need to address before this can be merged:
When you're ready for review, please mark the PR as ready and update the description accordingly. If you need any help or have questions during development, feel free to ask! Looking forward to seeing the completed implementation of webhook-triggered agent support. |
Thank you for starting work on webhook-triggered agent support. I notice this PR is marked as WIP, which is fine, but there are several items that need to be addressed before it can be considered for merging:
I'm marking this as a failure not because there's anything wrong with the code itself (which I haven't reviewed in detail), but because the PR as currently submitted is explicitly a work in progress and not ready for final review. Please feel free to update the PR when you're further along, and I'll be happy to review it again. |
9f0ee89
to
659999d
Compare
Thank you for this comprehensive PR that adds support for webhook-triggered agents in the Library! The changes look well-structured across the entire stack. However, before we can merge this PR, please complete the test plan you've outlined. Specifically, you still need to test:
These tests are crucial to ensure that the new functionality works as expected. Please complete them and check them off in the PR description. Additionally, I notice this is a large PR that touches multiple parts of the codebase. Once you've completed the testing, it would be helpful to have a brief summary of the test results to give reviewers confidence in the changes. Let me know if you encounter any issues while testing or if you need any clarification! |
Thanks for this comprehensive PR adding triggered-agent support to the Library! I appreciate the detailed explanation and clear organization of your changes. A few points to address before merging:
Once these points are addressed, this looks like a valuable addition to enable triggered agents in the Library. The implementation seems comprehensive across the stack. |
Thank you for this comprehensive PR adding triggered-agent support to the Library! The implementation looks thorough, spanning the entire stack from frontend to backend. Main feedback:
Overall, this is a valuable addition that will make triggered agents more accessible. Once you've completed the testing items and addressed these points, this PR should be ready for another review. |
c160f1b
to
9a5aec8
Compare
Thank you for your detailed PR! The changes to add triggered-agent support to the Library look comprehensive and well-structured. I have a few concerns before we can merge: TestingYour test plan looks thorough, but you've only completed testing for existing functionality and one aspect of the new functionality. Could you please complete testing for the remaining items:
PR Title ScopeYour changes span across multiple platform components (frontend, backend, blocks) as indicated by both the file changes and the labels. The current title User ID HandlingI noticed changes to several files in Once these items are addressed, we should be good to go with this PR. The implementation looks solid and will be a valuable addition to the platform! |
Thank you for this detailed PR adding webhook-triggered agent support to the Library! The implementation looks comprehensive, spanning the entire stack from frontend to backend. Incomplete TestingI noticed that several items in your test plan remain unchecked:
Before this PR can be merged, please complete this testing to ensure the functionality works as expected. Additional Feedback
Once you've completed testing of all the functionality listed in your test plan, please update the checklist and this PR should be ready for another review. |
Thank you for this comprehensive PR that adds triggered-agent support to the Library! The documentation and description of changes are excellent. However, I noticed that your test plan indicates two items are still unchecked:
Before we can approve this PR, please complete testing for these items to ensure the full functionality works as expected. This is especially important for a feature that spans across the entire stack. A few other minor points to consider:
Once you've completed the remaining test items, this PR will be ready for another review. Great work on this substantial feature addition! |
Thank you for submitting this comprehensive PR for triggered-agent support in the Library! The changes look well-structured and the description is thorough. A few things to address before we can merge:
Overall this looks like a valuable addition that will significantly improve the platform's capabilities. Once you've completed the remaining test items, this should be ready for final review. |
Thank you for this detailed PR implementing triggered-agent support in the Library! The description and implementation look comprehensive, covering changes across the entire stack. I noticed one issue that needs to be addressed before we can approve this PR:
A few additional points to consider:
Once you've addressed the checklist issue, we'll be able to proceed with the review. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
1 similar comment
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
…ion-for-webhook-triggered
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the missing approval stamp from backend
) | ||
|
||
|
||
# Fix Webhook <- NodeModel relations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any clarity on what the fix would be?
This pull request adds support for setting up (webhook-)triggered agents in the Library. It contains changes throughout the entire stack to make everything work in the various phases of a triggered agent's lifecycle: setup, execution, updates, deletion.
Setting up agents with webhook triggers was previously only possible in the Builder, limiting their use to the agent's creator only. To make it work in the Library, this change uses the previously introduced
AgentPreset
to store information on, instead of on the graph's nodes to which only a graph's creator has access.Changes 🏗️
Frontend:
AgentRunDraftView
to handle creating and editing PresetshideIfSingleCredentialAvailable
parameter toCredentialsInput
TypeBasedInput
AgentRunsSelectorList
AgentRunSummaryCard
for use for PresetsAgentStatusChip
to display general agent status (for now: Active / Inactive / Error)AgentRunsPage
IconClose
toIconCross
API:
LibraryAgent
propertieshas_external_trigger
,trigger_setup_info
,credentials_input_schema
POST /library/agents/{library_agent_id}/setup_trigger
endpointPOST /library/presets/{preset_id}/execute
endpointBackend:
POST /library/agents/{library_agent_id}/setup_trigger
endpointon_node_activate
intosetup_webhook_for_block
update_preset
anddelete_preset
endpointsnodes_input_masks
, generalized fromnode_credentials_input_map
)AgentPreset
->IntegrationWebhook
relationWebhookWithRelations
modelBaseWebhooksManager.get_manual_webhook(..)
to avoid unnecessary changes of the webhook URL: ignoreevents
to find matching webhook, and updateevents
if necessary.AgentPreset
API, models, and DB logicisDeleted
filter to get/list queriesuser_id
attribute toLibraryAgentPreset
modelcredentials
property toLibraryAgentPreset
modellibrary_db.update_preset(..)
replacement of existingInputPresets
library_db.update_preset(..)
more usage-friendly with separate parameters for updateable propertiesuser_id
checks to various DB functionsload_webhook_managers()
Checklist 📋
For code changes: