-
Notifications
You must be signed in to change notification settings - Fork 45.8k
feat(frontend): enforce auth through httpOnly cookies #10201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
0ubbe
wants to merge
29
commits into
Significant-Gravitas:dev
Choose a base branch
from
0ubbe:fix/enforce-httponly-cookies
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(frontend): enforce auth through httpOnly cookies #10201
0ubbe
wants to merge
29
commits into
Significant-Gravitas:dev
from
0ubbe:fix/enforce-httponly-cookies
+874
β288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for auto-gpt-docs-dev canceled.
|
β Deploy Preview for auto-gpt-docs canceled.
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes ποΈ
Implemented
httpOnly
cookies πͺ for secure session management ππ½ππ½ Moved all API requests to server-side execution for maximum XSS protection
httpOnly
cookies (no JWT tokens exposed to client)proxyApiRequest()
andproxyFileUpload()
server actions to handle all communication with APIBackendAPI._request()
to always use proxy approach for consistent securityπ§ Exception: WebSocket authentication requires client-side token exposure
getWebSocketToken()
server action to securely provide tokens only for WebSocket connectionsπ§Ή Abstracted implementation details into reusable helper functions
π Renamed
/reset_password
page to/reset-password
Checklist π
For code changes: