Skip to content

Allow filtering of PRs by review status or other criteria #1143

Open
@gtjoseph

Description

@gtjoseph

Description:
Allow filtering of PRs by review status

Justification:
If a PR is waiting for us to review it, we'll get to it eventually so we don't want it marked stale or auto-closed. However, we DO want the process applied to PRs where the PR submitter hasn't responded to requests for changes in a certain amount of time (review:changes_requested). Sure, we could manually add labels to the PRs to make them eligible or exempt from expiration but that defeats the purpose of the action. We could also write our own "pre-action" that automatically adds or removes labels based on review state but if we're going to do that, we might as well just do the expiration stuff ourselves as well.

I'm wondering... maybe a filter by generic search string would be better since you could call the REST /search/issues endpoint with it. Actually this is what the submitted PR does

Are you willing to submit a PR?
Yes! Sumitted.

Activity

added a commit that references this issue on Mar 14, 2024
c04cbed
HarithaVattikuti

HarithaVattikuti commented on Mar 14, 2024

@HarithaVattikuti
Contributor

Hello @gtjoseph
Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

gtjoseph

gtjoseph commented on Mar 14, 2024

@gtjoseph
Author

@HarithaVattikuti Actually I have a PR coming that adds the ability to retrieve issues and PRs using a search string and client.rest.search.issuesAndPullRequests instead of blanket retrieving all open issues and PRs from the owner/repo using client.rest.issues.listForRepo. I'm just testing it now.

added a commit that references this issue on Mar 14, 2024
4f61ec9
added 2 commits that reference this issue on Mar 15, 2024
fe80985
61ac807
changed the title [-]Allow filtering of PRs by review status[/-] [+]Allow filtering of PRs by review status or other criteria[/+] on Mar 19, 2024
added a commit that references this issue on Mar 20, 2024
1b80269
verdie-g

verdie-g commented on Apr 16, 2025

@verdie-g

@HarithaVattikuti could this get some attention? The stale bot is used in so many projects in Github, but closing a PR because it has not been reviewed by the project owner is extremely frustrating and really impacts the contributions of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @gtjoseph@verdie-g@HarithaVattikuti

      Issue actions

        Allow filtering of PRs by review status or other criteria · Issue #1143 · actions/stale