fix(opentelemetry): remove plugin attr set_ngx_var #12411
+19
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We changed the attribute of the Opentelemetry plugin to metadata in PR #11940. After that, users can set the
set_ngx_var
property in metadata. However, the generated template file still relies on theset_ngx_var
property from the plugin attribute to predefine variables https://github.com/apache/apisix/blob/master/apisix/cli/ops.lua#L553-L556, which will confuse users. This PR removes this judgment and allows this property to be controlled in metadata only.Which issue(s) this PR fixes:
Fixes #12402
Checklist