Skip to content

Use CoordinatorClient for fetching tier lookup #18142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 27, 2025

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 13, 2025

Description

This PR is part of the effort to phase out DruidLeaderClient and utilize CoordinatorClient to interact with Coordinators. This particular PR focuses on

  • Implementing interface fetchLookupForTier for Coordinator Client.
  • Replacing DruidLeaderClient in LookupReferencesManager with CoordinatorClient.

Key changed/added classes in this PR
  • CoordinatorClientImpl.fetchLookupForTier()

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, left minor suggestions.

@uds5501 uds5501 requested a review from kfaraz June 16, 2025 15:39
@uds5501 uds5501 requested a review from kfaraz June 17, 2025 07:03
Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@uds5501 uds5501 closed this Jun 26, 2025
@uds5501 uds5501 reopened this Jun 26, 2025
@kfaraz
Copy link
Contributor

kfaraz commented Jun 27, 2025

Thanks for keeping at this PR, @uds5501 !

Since we have had two consecutive successful CI runs, I think we can go ahead and merge this.

@kfaraz kfaraz merged commit 6b3cb50 into apache:master Jun 27, 2025
133 of 136 checks passed
uds5501 added a commit to uds5501/druid that referenced this pull request Jul 2, 2025
cryptoe pushed a commit that referenced this pull request Jul 2, 2025
uds5501 added a commit to uds5501/druid that referenced this pull request Jul 2, 2025
uds5501 added a commit to uds5501/druid that referenced this pull request Jul 3, 2025
uds5501 added a commit to uds5501/druid that referenced this pull request Jul 4, 2025
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
kfaraz added a commit that referenced this pull request Jul 23, 2025
Description:
This is a follow up to the work done by @uds5501 in #18142 , #18192 and #18195 
to replace usages of `DruidLeaderClient` with a `ServiceClient`-based implementation.

Changes:
- Remove usages of `DruidLeaderClient` in extensions `druid-basic-security` and `druid-catalog`
- Use `ServiceClient` to make HTTP calls instead
- Remove classes `DruidLeaderClient`, `CoordinatorDiscoveryModule`
- Add embedded test `CatalogCompactionTest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants