-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Use CoordinatorClient for fetching tier lookup #18142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, left minor suggestions.
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClient.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClientImpl.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java
Outdated
Show resolved
Hide resolved
This reverts commit 01d2a1e.
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Fixed
Show fixed
Hide fixed
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClientImpl.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for keeping at this PR, @uds5501 ! Since we have had two consecutive successful CI runs, I think we can go ahead and merge this. |
This reverts commit 6b3cb50.
…e#18142)" (apache#18189)" This reverts commit b53e08c.
…e#18142)" (apache#18189)" This reverts commit b53e08c.
…e#18142)" (apache#18189)" This reverts commit b53e08c.
Description: This is a follow up to the work done by @uds5501 in #18142 , #18192 and #18195 to replace usages of `DruidLeaderClient` with a `ServiceClient`-based implementation. Changes: - Remove usages of `DruidLeaderClient` in extensions `druid-basic-security` and `druid-catalog` - Use `ServiceClient` to make HTTP calls instead - Remove classes `DruidLeaderClient`, `CoordinatorDiscoveryModule` - Add embedded test `CatalogCompactionTest`
Description
This PR is part of the effort to phase out
DruidLeaderClient
and utilizeCoordinatorClient
to interact with Coordinators. This particular PR focuses onfetchLookupForTier
for Coordinator Client.DruidLeaderClient
inLookupReferencesManager
withCoordinatorClient
.Key changed/added classes in this PR
CoordinatorClientImpl.fetchLookupForTier()
This PR has: