Update some dependencies #18154
Open
Update some dependencies #18154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Jun 23, 2025
| @@ -69,7 +69,7 @@ public void testLargeString() throws Exception | |||
| assertExpected(ImmutableList.of(new SerializablePairLongString( | |||
| 100L, | |||
| randomStringUtils.randomAlphanumeric(2 * 1024 * 1024) | |||
| )), 2097182, 2103140); | |||
| )), 2097182, 2103139); | |||
There was a problem hiding this comment.
What is happening here? It seems the expectedCompressedSize is changing- what drives this, and is it backwards compatible with older readers and writers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that some deps are overriden with lower versions (for ex:
lang3).And wanted to enable the enforcer plugins
requireUpperBoundDepsto make sure that doesn't happen...however that uncovered a lot of downgrades...here are few which seemed more-or-less okay.most notable upgrades:
guavais upgraded to32.1.3-jreslf4j1->slf4j2which implied to upgrade to uselog4j-slf4j2kotlin-stdlibupgraded from1.6.10to1.9.25