Load the existing pods when initializing kubernetes client to cleanup terminated app pods #7101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7101 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 697 697
Lines 43214 43243 +29
Branches 5855 5859 +4
======================================
- Misses 43214 43243 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @pan3793 |
pan3793
reviewed
Jun 19, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala
Outdated
Show resolved
Hide resolved
|
How about now? @pan3793 Due now we always cleanup terminated pods, so I think it is not necessary to involve a new config to cleanup them on kubernetes client init. |
|
my major concern is that something might go wrong during |
pan3793
approved these changes
Jun 20, 2025
turboFei
added a commit
that referenced
this pull request
Jun 23, 2025
…ient to cleanup terminated app pods ### Why are the changes needed? To prevent the terminated app pods leak if the events missed during kyuubi server restart. ### How was this patch tested? Manual test. ``` :2025-06-17 17:50:37.275 INFO [main] org.apache.kyuubi.engine.KubernetesApplicationOperation: [KubernetesInfo(Some(28),Some(dls-prod))] Found existing pod kyuubi-xb406fc5-7b0b-4fdf-8531-929ed2ae250d-8998-5b406fc5-7b0b-4fdf-8531-929ed2ae250d-8998-90c0b328-930f-11ed-a1eb-0242ac120002-0-20250423211008-grectg-stm-17da59fe-caf4-41e4-a12f-6c1ed9a293f9-driver with label: kyuubi-unique-tag=17da59fe-caf4-41e4-a12f-6c1ed9a293f9 in app state FINISHED, marking it as terminated 2025-06-17 17:50:37.278 INFO [main] org.apache.kyuubi.engine.KubernetesApplicationOperation: [KubernetesInfo(Some(28),Some(dls-prod))] Found existing pod kyuubi-xb406fc5-7b0b-4fdf-8531-929ed2ae250d-8998-5b406fc5-7b0b-4fdf-8531-929ed2ae250d-8998-90c0b328-930f-11ed-a1eb-0242ac120002-0-20250423212011-gpdtsi-stm-6a23000f-10be-4a42-ae62-4fa2da8fac07-driver with label: kyuubi-unique-tag=6a23000f-10be-4a42-ae62-4fa2da8fac07 in app state FINISHED, marking it as terminated ``` The pods are cleaned up eventually. <img width="664" alt="image" src="https://github.com/user-attachments/assets/8cf58f61-065f-4fb0-9718-2e3c00e8d2e0" /> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7101 from turboFei/pod_cleanup. Closes #7101 7f76cf5 [Wang, Fei] async 11c9db2 [Wang, Fei] cleanup Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 302b5fa) Signed-off-by: Wang, Fei <fwang12@ebay.com>
|
thanks, merged to main and branch-1.10 |
|
@turboFei branch-1.10 broken after merging this PR |
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Jun 26, 2025
pan3793
pushed a commit
that referenced
this pull request
Jul 2, 2025
### Why are the changes needed? Address comment: #7101 (comment) ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7116 from turboFei/fix_conflicts. Closes #7101 f25f487 [Wang, Fei] [KYUUBI #7101][1.10][FOLLOWUP] Fix code broken Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To prevent the terminated app pods leak if the events missed during kyuubi server restart.
How was this patch tested?
Manual test.
The pods are cleaned up eventually.
Was this patch authored or co-authored using generative AI tooling?
No.