Skip to content

Commit c045e19

Browse files
Enable GitHub Issues
1 parent 51fd5f0 commit c045e19

File tree

7 files changed

+132
-39
lines changed

7 files changed

+132
-39
lines changed

.asf.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,11 @@ github:
2929
rebase: true
3030
autolink_jira:
3131
- MCOMPILER
32+
del_branch_on_merge: true
33+
features:
34+
issues: true
3235
notifications:
3336
commits: commits@maven.apache.org
3437
issues: issues@maven.apache.org
3538
pullrequests: issues@maven.apache.org
36-
jira_options: link label comment
39+
jira_options: link label

.github/ISSUE_TEMPLATE/BUG.yml

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
19+
20+
name: Bug Report
21+
description: File a bug report
22+
labels: ["bug"]
23+
24+
body:
25+
- type: markdown
26+
attributes:
27+
value: |
28+
Thanks for taking the time to fill out this bug report.
29+
30+
Simple fixes in single PRs do not require issues.
31+
32+
**Do you use the latest project version?**
33+
34+
- type: input
35+
id: version
36+
attributes:
37+
label: Affected version
38+
validations:
39+
required: true
40+
41+
- type: textarea
42+
id: massage
43+
attributes:
44+
label: Bug description
45+
validations:
46+
required: true
47+
48+

.github/ISSUE_TEMPLATE/FEATURE.yml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
19+
20+
name: Feature request
21+
description: File a proposal for new feature, improvement
22+
labels: ["enhancement"]
23+
24+
body:
25+
- type: markdown
26+
attributes:
27+
value: |
28+
Thanks for taking the time to fill out this new feature, improvement proposal.
29+
30+
- type: textarea
31+
id: massage
32+
attributes:
33+
label: New feature, improvement proposal
34+
validations:
35+
required: true

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
19+
20+
blank_issues_enabled: false
21+
22+
contact_links:
23+
24+
- name: Project Mailing Lists
25+
url: https://maven.apache.org/mailing-lists.html
26+
about: Please ask a question or discuss here
27+
28+
- name: Old JIRA Issues
29+
url: https://issues.apache.org/jira/projects/MCOMPILER
30+
about: Please search old JIRA issues

.github/pull_request_template.md

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
1-
Following this checklist to help us incorporate your
1+
Following this checklist to help us incorporate your
22
contribution quickly and easily:
33

4-
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
5-
for the change (usually before you start working on it). Trivial changes like typos do not
6-
require a JIRA issue. Your pull request should address just this issue, without
7-
pulling in other changes.
8-
- [ ] Each commit in the pull request should have a meaningful subject line and body.
9-
- [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
10-
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
11-
is to use the JIRA issue title in the pull request title and in the first line of the
12-
commit message.
13-
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
14-
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
15-
be performed on your pull request automatically.
16-
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
4+
- [ ] Your pull request should address just one issue, without pulling in other changes.
5+
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
6+
- [ ] Each commit in the pull request should have a meaningful subject line and body.
7+
Note that commits might be squashed by a maintainer on merge.
8+
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
9+
This may not always be possible but is a best-practice.
10+
- [ ] Run `mvn verify` to make sure basic checks pass.
11+
A more thorough check will be performed on your pull request automatically.
12+
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
1713

1814
If your pull request is about ~20 lines of code you don't need to sign an
1915
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
2016
please ask on the developers list.
2117

22-
To make clear that you license your contribution under
18+
To make clear that you license your contribution under
2319
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
2420
you have to acknowledge this by using the following check-box.
2521

26-
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
27-
28-
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
29-
22+
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
23+
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

README.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
Contributing to [Apache Maven Compiler Plugin](https://maven.apache.org/plugins/maven-compiler-plugin/)
1818
======================
1919

20-
[![ASF Jira](https://img.shields.io/endpoint?url=https%3A%2F%2Fmaven.apache.org%2Fbadges%2Fasf_jira-MCOMPILER.json)][jira]
2120
[![Apache License, Version 2.0, January 2004](https://img.shields.io/github/license/apache/maven.svg?label=License)][license]
2221
[![Maven Central](https://img.shields.io/maven-central/v/org.apache.maven.plugins/maven-compiler-plugin.svg?label=Maven%20Central&versionPrefix=3.)](https://search.maven.org/artifact/org.apache.maven.plugins/maven-compiler-plugin)
2322
[![Maven Central](https://img.shields.io/maven-central/v/org.apache.maven.plugins/maven-compiler-plugin.svg?label=Maven%20Central)](https://search.maven.org/artifact/org.apache.maven.plugins/maven-compiler-plugin)
@@ -37,7 +36,6 @@ things.
3736
Getting Started
3837
---------------
3938

40-
+ Make sure you have a [JIRA account](https://issues.apache.org/jira/).
4139
+ Make sure you have a [GitHub account](https://github.com/signup/free).
4240
+ If you're planning to implement a new feature, it makes sense to discuss your changes
4341
on the [dev list][ml-list] first.
@@ -63,37 +61,22 @@ There are some guidelines which will make applying PRs easier for us:
6361
+ Create minimal diffs - disable on save actions like reformat source code or organize imports.
6462
If you feel the source code should be reformatted, create a separate PR for this change.
6563
+ Check for unnecessary whitespace with `git diff --check` before committing.
66-
+ Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
67-
```
68-
[MCOMPILER-XXX] - Subject of the JIRA Ticket
69-
Optional supplemental description.
70-
```
7164
+ Make sure you have added the necessary tests (JUnit/IT) for your changes.
7265
+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was accidentally broken.
7366
+ Submit a pull request to the repository in the Apache organization.
74-
+ Update your JIRA ticket and include a link to the pull request in the ticket.
7567

7668
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement][cla].
7769

78-
Making Trivial Changes
79-
----------------------
80-
81-
For changes of a trivial nature to comments and documentation, it is not always
82-
necessary to create a new ticket in JIRA. In this case, it is appropriate to
83-
start the first line of a commit with '(doc)' instead of a ticket number.
84-
8570
Additional Resources
8671
--------------------
8772

8873
+ [Contributing patches](https://maven.apache.org/guides/development/guide-maven-development.html#Creating_and_submitting_a_patch)
89-
+ [Apache Maven Compiler JIRA project page][jira]
9074
+ [Contributor License Agreement][cla]
9175
+ [General GitHub documentation](https://help.github.com/)
9276
+ [GitHub pull request documentation](https://help.github.com/send-pull-requests/)
9377
+ [Apache Maven Twitter Account](https://twitter.com/ASFMavenProject)
9478
+ #Maven IRC channel on freenode.org
9579

96-
[jira]: https://issues.apache.org/jira/projects/MCOMPILER/
9780
[license]: https://www.apache.org/licenses/LICENSE-2.0
9881
[ml-list]: http://maven.apache.org/mailing-lists.html
9982
[code-style]: https://maven.apache.org/developers/conventions/code.html

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ under the License.
6666
<url>https://github.com/apache/maven-compiler-plugin/tree/${project.scm.tag}</url>
6767
</scm>
6868
<issueManagement>
69-
<system>JIRA</system>
70-
<url>https://issues.apache.org/jira/browse/MCOMPILER</url>
69+
<system>GitHub</system>
70+
<url>https://github.com/apache/maven-compiler-plugin/issues</url>
7171
</issueManagement>
7272
<ciManagement>
7373
<system>Jenkins</system>

0 commit comments

Comments
 (0)