[MRESOLVER-718] Support dependencyManagement task

[jira-importer]

Per Nyfelt opened MRESOLVER-718 and commented

There does not seem to be a way to support BOM's when declaring the dependencies in the build.xml only (not relying on an external pom file)

Adding a dependency with the type pom and scope import to a dependencies section results in

[resolve] Unknown scope 'import' for dependency

To be in line with how boms are used in maven, it would make sense to add a dependencyManagement task where BOM's can be imported.

Given such an import, it would also make sense to allow for coords without version (which currently throws an exception)

---

No further details from MRESOLVER-718

[jira-importer]

Per Nyfelt commented

This could either look something like this (separate section, similar to the pom layout)

<dependencyManagement id="dm1">
  <dependencies>
    <dependency groupId='org.junit' artifactId='junit-bom' version='5.12.2', type='pom', scope='import'/>
  </dependencies>
</dependencyManagement>

  <dependencies id='d1' references='dm1'>
    <dependency groupId='org.junit.jupiter' artifactId= 'junit-jupiter-engine' scope='test'/>
    <dependency groupId='org.junit.platform' artifactId= 'junit-platform-launcher' scope='test'/>
  </dependencies>
 

or something like this (inline in the dependencies section)

  <dependencies id='d1'>
    <dependencyManagement groupId='org.junit' artifactId='junit-bom' version='5.12.2', type='pom', scope='import'/>
    <dependency groupId='org.junit.jupiter' artifactId= 'junit-jupiter-engine' scope='test'/>
    <dependency groupId='org.junit.platform' artifactId= 'junit-platform-launcher' scope='test'/>
  </dependencies>    

    

[jira-importer]

Tamas Cservenak commented

Sadly, "import" scope is an ugly hack that is done in Maven: Resolver have no idea about it! It all happens in Maven, and the whole logic not even enters Resolver. Plus, the whole code in Maven doing this is not quite reusable, so it would mean "cleanroom reimplementation" here (think recursive imports, etc).

[jira-importer]

Per Nyfelt commented

I found a quite decent workaround that is supported today i.e. to generate a pom and "register" it with the pom task ( <pom file="${basedir}/target/myProject.pom /> ) before the resolve task is called. For my case, I added a dependencyManagement type and created a createPom task that creates the pom file and populates the dependency management and dependencies sections respectively based on the id refs given to the createPom task as parameters. The result is (i think) much cleaner/better than the equivalent ant + ivy combination.

[jira-importer]

Tamas Cservenak commented

Just to add to this :)

You may get good use of jbang + toolbox:

[cstamas@angeleyes ~]$ jbang toolbox@maveniverse classpath --boms=org.junit:junit-bom:5.12.2 org.junit.jupiter:junit-jupiter-api
/home/cstamas/.m2/repository-oss/org/junit/jupiter/junit-jupiter-api/5.12.2/junit-jupiter-api-5.12.2.jar:/home/cstamas/.m2/repository-oss/org/opentest4j/opentest4j/1.3.0/opentest4j-1.3.0.jar:/home/cstamas/.m2/repository-oss/org/junit/platform/junit-platform-commons/1.12.2/junit-platform-commons-1.12.2.jar:/home/cstamas/.m2/repository-oss/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
[cstamas@angeleyes ~]$  

This command "just" ensures they are in local repo:

[cstamas@angeleyes ~]$ jbang toolbox@maveniverse resolve-transitive --boms=org.junit:junit-bom:5.12.2 org.junit.jupiter:junit-jupiter-engine,org.junit.platform:junit-platform-launcher
  ------------------------------
  org.opentest4j:opentest4j:jar:1.3.0 -- module org.opentest4j
  org.junit.jupiter:junit-jupiter-engine:jar:5.12.2 -- module org.junit.jupiter.engine
  org.apiguardian:apiguardian-api:jar:1.1.2 -- module org.apiguardian.api
  org.junit.platform:junit-platform-engine:jar:1.12.2 -- module org.junit.platform.engine
  org.junit.platform:junit-platform-commons:jar:1.12.2 -- module org.junit.platform.commons
  org.junit.jupiter:junit-jupiter-api:jar:5.12.2 -- module org.junit.jupiter.api
  ------------------------------
  Total of 6 artifacts (931.8 KiB)
  ------------------------------
  ------------------------------
  org.opentest4j:opentest4j:jar:1.3.0 -- module org.opentest4j
  org.apiguardian:apiguardian-api:jar:1.1.2 -- module org.apiguardian.api
  org.junit.platform:junit-platform-engine:jar:1.12.2 -- module org.junit.platform.engine
  org.junit.platform:junit-platform-commons:jar:1.12.2 -- module org.junit.platform.commons
  org.junit.platform:junit-platform-launcher:jar:1.12.2 -- module org.junit.platform.launcher
  ------------------------------
  Total of 5 artifacts (621.5 KiB)
  ------------------------------
Total of 11 artifacts (1.5 MiB)
------------------------------
[cstamas@angeleyes ~]$

[jira-importer]

Tamas Cservenak commented

Combined copy w/ flat (flat directory) sink:

[cstamas@angeleyes MRESOLVER-718]$ ll -a
total 0
drwxr-xr-x. 1 cstamas cstamas    0 May 23 18:38 .
drwxr-xr-x. 1 cstamas cstamas 2108 May 23 18:36 ..
[cstamas@angeleyes MRESOLVER-718]$ tree -a
.0 directories, 0 files
[cstamas@angeleyes MRESOLVER-718]$ jbang toolbox@maveniverse copy-transitive --boms=org.junit:junit-bom:5.12.2 "flat(lib)"  org.junit.jupiter:junit-jupiter-engine,org.junit.platform:junit-platform-launcher
Copied 11 artifacts
[cstamas@angeleyes MRESOLVER-718]$ tree
.
└── lib
    ├── apiguardian-api-1.1.2.jar
    ├── junit-jupiter-api-5.12.2.jar
    ├── junit-jupiter-engine-5.12.2.jar
    ├── junit-platform-commons-1.12.2.jar
    ├── junit-platform-engine-1.12.2.jar
    ├── junit-platform-launcher-1.12.2.jar
    └── opentest4j-1.3.0.jar

2 directories, 7 files
[cstamas@angeleyes MRESOLVER-718]$  

[jira-importer]

Tamas Cservenak commented

Also, no Jbang needed as toolbox CLI is on Central:

[cstamas@angeleyes MRESOLVER-718]$ curl https://repo.maven.apache.org/maven2/eu/maveniverse/maven/plugins/toolbox/0.10.1/toolbox-0.10.1-cli.jar > toolbox.jar
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8519k  100 8519k    0     0  4014k      0  0:00:02  0:00:02 --:--:-- 4016k
[cstamas@angeleyes MRESOLVER-718]$ java -jar toolbox.jar copy-transitive --boms=org.junit:junit-bom:5.12.2 "flat(lib)"  org.junit.jupiter:junit-jupiter-engine,org.junit.platform:junit-platform-launcher
Copied 11 artifacts
[cstamas@angeleyes MRESOLVER-718]$ tree .
.
├── lib
│   ├── apiguardian-api-1.1.2.jar
│   ├── junit-jupiter-api-5.12.2.jar
│   ├── junit-jupiter-engine-5.12.2.jar
│   ├── junit-platform-commons-1.12.2.jar
│   ├── junit-platform-engine-1.12.2.jar
│   ├── junit-platform-launcher-1.12.2.jar
│   └── opentest4j-1.3.0.jar
└── toolbox.jar

2 directories, 8 files
[cstamas@angeleyes MRESOLVER-718]$