chore: Simplify immutable collections implementation by using standard Java APIs #2363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Java APIs - Replace custom List implementation with standard List.of() and List.copyOf() - Remove unnecessary custom list implementations (List1, List2, ListN, etc.) - Remove ROProperties implementation as it's no longer needed - Add documentation note referencing JDK issue JDK-8323729 - Reduce code complexity and maintenance burden by leveraging JDK standard APIs This change aligns with the goal of using standard Java APIs where possible instead of maintaining custom implementations.
Bukama
reviewed
May 21, 2025
Bukama
approved these changes
May 21, 2025
cstamas
reviewed
May 23, 2025
cstamas
approved these changes
May 23, 2025
|
one landmine to watch out for is that JDK's immutable collections can't contain null. List.of("duke").contains(null); // even contains throws NPE |
|
8 tasks
Co-authored-by: Tamas Cservenak <tamas@cservenak.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns with the goal of using standard Java APIs where possible
instead of maintaining custom implementations.