Unlocking radios on RPI with a dedicated service

[igorpecovnik]

Description

While doing last prerelease testing I tried booting on Zero2W, which only has wireless connection. I could not enable connection because rfblock comes up enabled, thus nothing wireless wise works.

Adding a systemd service that ublock it without adding additional dependency rfkill.

Does it make sense to make this OS wide?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[coderabbitai]

Walkthrough

Two new functions were added to the bcm2711 family configuration. The first function clones a Raspberry Pi firmware repository into the target root filesystem under /lib/firmware/updates/brcm and removes the .git directory and README file from that location. The second function creates a systemd oneshot service unit named unblock-rfkill.service inside the target root filesystem, which writes 1 to all rfkill state files to unblock rfkill devices without the rfkill binary. This service is enabled to start at boot and runs after multi-user.target. No other changes were made.

Suggested labels

ready to merge

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a79364e and 4bf6641.

📒 Files selected for processing (1)

• config/sources/families/bcm2711.conf (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• config/sources/families/bcm2711.conf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

config/sources/families/bcm2711.conf (1)

258-276: Implementation looks good with a simple and effective approach.

This is a clean solution to unblock rfkill devices without requiring the rfkill binary. The systemd service is well-structured with appropriate timing (after multi-user.target) and type (oneshot with RemainAfterExit=true).

Consider adding a brief comment at the top of the function explaining the specific issue this addresses (rfblock enabled by default on boot for certain RPI models like Zero 2 W), which would help future maintainers understand the rationale.

function pre_install_distribution_specific__unblock_rfkill() {
+	# Raspberry Pi Zero 2 W and potentially other models have rfkill block enabled 
+	# by default at boot, which prevents wireless functionality from working
	# Create a systemd service to unblock rfkill
	cat > "${SDCARD}/etc/systemd/system/unblock-rfkill.service" <<- EOT

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0f708d and a79364e.

📒 Files selected for processing (1)

• config/sources/families/bcm2711.conf (1 hunks)

[igorpecovnik]

Tested twice, working.