-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
AE for cloud, add description for vendor #8299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the fallback descriptions for kernel branch options within the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
lib/functions/configuration/interactive.sh (1)
236-236
: Legacy branch description: redundant slash before “kernel”
The updated descriptionOld stable / Legacy / kernel
leaves an extra slash. Consider merging “Legacy” and “kernel” for clarity.Apply this diff:
- description="Old stable / Legacy / kernel" + description="Old stable / Legacy kernel"🧰 Tools
🪛 GitHub Actions: Shellcheck - PR #8299 ("AE for cloud, add description for vendor")
[error] ShellCheck detected critical errors in lib/ code causing the pipeline to fail with exit code 1.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/functions/configuration/interactive.sh
(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
lib/functions/configuration/interactive.sh
[error] 244-244: Couldn't parse this case item. Fix to allow more checks.
(SC1073)
🪛 GitHub Actions: Shellcheck - PR #8299 ("AE for cloud, add description for vendor")
lib/functions/configuration/interactive.sh
[error] ShellCheck detected critical errors in lib/ code causing the pipeline to fail with exit code 1.
🔇 Additional comments (1)
lib/functions/configuration/interactive.sh (1)
242-242
: Cloud branch description uses correct American spelling
The change from “optimised” to “optimized” aligns with US English conventions.🧰 Tools
🪛 GitHub Actions: Shellcheck - PR #8299 ("AE for cloud, add description for vendor")
[error] ShellCheck detected critical errors in lib/ code causing the pipeline to fail with exit code 1.
* AE for cloud, add description for vendor * fixes
Description
As per title
How Has This Been Tested?
Checklist: