Skip to content

beagle: Enable modules for ethernet and serial over USB #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

Ayush1325
Copy link
Member

Description

Enable kernel modules required to make Ethernet and serial over USB work as described here.

Tested on PocketBeagle 2.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

- BeagleBoard.org boards normally ship with USB cdc enabled to allow
  network sharing and ssh support over usb.
- This is specially important for boards like pocketbeagle2 since it
  does not have built-in wifi.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
- Allows for network share when usb serial is not required.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325 Ayush1325 requested a review from Grippy98 as a code owner June 23, 2025 06:41
Copy link
Contributor

coderabbitai bot commented Jun 23, 2025

Walkthrough

Two new kernel configuration options, CONFIG_USB_ETH and CONFIG_USB_CDC_COMPOSITE, were added as modules in the Linux kernel configuration for the k3-beagle-edge platform. These options enable support for USB Ethernet devices and composite CDC USB devices. No existing configuration options were removed or modified, and there were no changes to exported or public entity declarations.

Suggested labels

ready to merge

Suggested reviewers

  • igorpecovnik
  • Grippy98

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9835d6 and e3f5a22.

📒 Files selected for processing (1)
  • config/kernel/linux-k3-beagle-edge.config (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Shell script analysis
  • GitHub Check: Check kernel security options
🔇 Additional comments (2)
config/kernel/linux-k3-beagle-edge.config (2)

721-721: Approve enabling USB Ethernet module (CONFIG_USB_ETH=m)
This adds support for USB Ethernet devices as a loadable module on the k3-beagle-edge. Confirm that CONFIG_USB_ETH is defined in the kernel’s Kconfig and pulls in the correct driver.

Run the following script to verify the option exists:

#!/bin/bash
# Verify CONFIG_USB_ETH is defined in drivers/net/usb/Kconfig
grep -R "config USB_ETH" -n drivers/net/usb

723-723: ```shell
#!/bin/bash

Search entire repository for the CDC composite USB gadget config entry

grep -R "config USB_CDC_COMPOSITE" -n .

Fallback: search for any mention of CDC_COMPOSITE in Kconfig files

grep -R "CDC_COMPOSITE" -n . | grep -i Kconfig


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIBEjQiSK4AUQwVSMhmRW9pSAAzfD4SXFhKclDMekRKeDRffCk+AFUAZQAhABpo+2wBZnUaejlIbGq+AEFZUdgARgBmACYAVnRkW0gMRzi+AA5FgBYO9HhmZAJIMnSPAGsykl8s2hzkcgZpRGd5Ar5kkruKjBVGp1BSsbAYeAMajwfBYBqUSCtNoaGAIZB5cFiGFpLzqeSoARoar0WFhUooZjcSJsDC4aGkpSIBgUeBxejwLBoPwkPKUMhvehEJChAAUsFwuG4iA4AHoZULEJohSVehomMwZRDrtwZgs5jKGAA2JY7ARzGYMfZLBY7U1LJYzfYWgCctBmzroJAA7DsSIaGABKFHuRiwTCkZBhqSQOJkMIhKKIbiieB5SF1LzyUl/az4Bi3XBteKJDwLSBKCSQkgaNzktB4WCFBQYNMUU7oWilfwYN5hfBkjy8fAiMQAcmQitkGSI2HgSlx5EQRzDyGTFG+bHoXOqXjyYH8lZIAHcjpUUD2vNglPR1TTcMgOaCqSQAB4KJT2UTiWGIYPkx6pum34YMgtD9hg+ChByuAUNkvbkEekBHs4EIYEQS7oICmHyEoyaAuwobhrkUYeHU/hoLQ8ixlgbAUKQW5YdwvS4ogpTslgYFHiBMHxMwmTZJEv6ooO3i+P4QQhCgyBoAwbyIIgrIZNQkDipK0pysqsCquqMrOMwaiYDKAizl4tAykxPgynsCz7DWBj6MY4BQGQJJ5DgBDEGQyiDKCd5cLw/DCF+ki5MMTBKFQqjqFoOgOSYUBwKgqCYO5hCkOQVA+be7BcFQiEOE4LgxvI4XKFFmjaLoYCGI5pgGEwLbwEQMq3BQ5BeDKC7YC+YDXHMYBxAkkRgHQpBqrCaZEBwBjRLNBgWJA4wAJKeRl1CJo4zCfPwbkMGGaHSG4R7gceiLtPu9zrfQrXtc2k3YJl2L8NwwHIEefIdteqz8U8glcAABgAwgA8gAcgAYktADiAD6SIw8k0AABL/Zh9BA2DkOw/DgMACKAzDIMALJWMDLRLdAyT/X+0gePgL3YsglwCBkDjcNwhShN8Z1tJAvxduU5YkJWclo0++AKTQkB44DkAioDLDMOCQGM5AuPC1W0teESiABjzQsi9IRz+EmwVSJmNPcoqO0DvrDX3Y9pL+FtHLIJi+30aeWEQc9r1IR9zvwiSfC0EgVy0HZC3jF4NCOyBfa20oDDa3HyD4G5r4cxQPlNkxLOQhctLqPAh32ZAoP9ntRFnP2mec1EufMQX7B4kLyfOPS8fvf4mQUSQADc/AYJmkA3fcd1NQ9ne+6r3ekbQ141rN0RGA5BjxYXrmpat3lRNltK5Wg+WbdtYWKGVagVbF1Xr05vnqDDc6IDDB4l+9tAw4qzihGvG8kHMeQlhoAWAsAADDMPIhplggIEPsJ0XoSDOh2GgeYcxbQzFtF6NAXo8hzH2DZKqNUN63gfk/F+Gtjx0Bhi5QhQA= -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

<details open="true">
<summary>🧪 Generate Unit Tests</summary>

- [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} -->   Create PR with Unit Tests
- [ ] <!-- {"checkboxId": "07f1e7d6-8a8e-4e23-9900-8731c2c87f58", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} -->   Post Copyable Unit Tests in Comment

</details>

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=armbian/build&utm_content=8324):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai auto-generate unit tests` to generate unit tests for this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@github-actions github-actions bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines labels Jun 23, 2025
@coderabbitai coderabbitai bot requested a review from igorpecovnik June 23, 2025 06:41
@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jun 23, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label Jun 23, 2025
@igorpecovnik igorpecovnik merged commit d18ab3c into armbian:main Jun 23, 2025
13 checks passed
@Ayush1325 Ayush1325 deleted the usb-share branch June 24, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants