-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
orangepi-4a: add initial mainline kernel support #8330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change introduces support for the Orange Pi 4A board by adding a new board configuration file ( Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
config/boards/orangepi-4a.csc (2)
4-6
: Complete the hardware-specific configuration fields.Several critical configuration fields are incomplete and marked as "fixme":
BOOTCONFIG
needs the correct U-Boot defconfig for Orange Pi 4AOVERLAY_PREFIX
should match the actual device tree naming conventionThese hardware-specific configurations require knowledge of the Orange Pi 4A's actual device tree and U-Boot support. Please verify the correct values with the hardware documentation or existing working configurations.
4-4
: Add board maintainer information.The
BOARD_MAINTAINER
field is empty. Please add maintainer contact information for ongoing support and issue tracking.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
patch/kernel/archive/sunxi-6.16/add-orangepi-4a.patch
is excluded by!patch/**
📒 Files selected for processing (3)
config/boards/orangepi-4a.csc
(1 hunks)config/kernel/linux-sun55iw3-edge.config
(1 hunks)config/sources/families/sun55iw3.conf
(1 hunks)
🔇 Additional comments (2)
config/boards/orangepi-4a.csc (1)
9-9
: Verify the device tree file path.The
BOOT_FDT_FILE
is marked as "fixme" and may not reflect the actual device tree file that will be available for the Orange Pi 4A in mainline kernel 6.16-rc3.Please verify that
sun55i-t527-orangepi-4a.dtb
will be available in the mainline kernel or if a different device tree file should be used.config/kernel/linux-sun55iw3-edge.config (1)
1-1465
: Comprehensive kernel configuration appropriate for initial mainline support.This kernel configuration provides extensive hardware support and debugging capabilities suitable for initial Orange Pi 4A mainline kernel development. Key highlights:
- Proper ARM64 and Sunxi platform support enabled
- Comprehensive driver support for networking, storage, multimedia, and USB
- Debug features enabled for development and troubleshooting
- Security and virtualization features included
- Preemptible kernel configuration for better responsiveness
The extensive feature set aligns well with the goal of providing a foundation for further development as mentioned in the PR objectives.
Alright this is kind of interesting. I tried to bump this to the v3 sent upstream but the framework does not accept this patch which just moves some stuff around in the same file: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250628161608.3072968-4-wens@kernel.org/ For now I strip this patch since there is no function change. |
Description
This PR (very sloppily) adds support to build mainline kernels for the Orange Pi 4A.
It does not allow building ready-to-use images due to lack of proper U-Boot.
Maybe somebody wants to use it as a base to tinker further.
Based on bare mainline w/o standard patchset and this: https://lore.kernel.org/all/20250619173007.3367034-1-wens@kernel.org/
How Has This Been Tested?
Checklist: