Skip to content

jkube-healthcheck-spring-boot enricher: rename property management.health.probes.enabled #3690

@claudio4j

Description

@claudio4j

The jkube-healthcheck-spring-boot enricher says about setting management.health.probes.enabled to enable the liveness/readiness probes, however since spring boot 2.3.2 that property is deprecated/removed, it was renamed to management.endpoint.health.probes.enabled.

Read about the spring boot Kubernetes Probes for the correct property name.

Activity

rohanKanojia

rohanKanojia commented on Mar 7, 2025

@rohanKanojia
Member

@claudio4j : Isn't the generation of liveness and readiness probes automatically enabled when the spring-boot-actuator dependency is added?

if (getContext().getProjectClassLoaders().isClassInCompileClasspath(true, REQUIRED_CLASSES)) {
return buildProbe(initialDelay, period, timeout, failureTh, successTh, suffix);
}

protected static final String[] REQUIRED_CLASSES = {
"org.springframework.boot.actuate.health.HealthIndicator",

Do you mean the documentation is showing wrong information?

claudio4j

claudio4j commented on Mar 7, 2025

@claudio4j
Author

The documentation says about management.health.probes.enabled and the SpringBootConfiguration.java uses the old property name.

claudio4j

claudio4j commented on Mar 7, 2025

@claudio4j
Author

Isn't the generation of liveness and readiness probes automatically enabled when the spring-boot-actuator

Not setting the management.health.probes.enabled, the Deployment sets the /actuator/health for both liveness and readiness probes.

claudio4j

claudio4j commented on Mar 7, 2025

@claudio4j
Author

If you are going to update the documentation, can you also write about setting the management.endpoints.web.base-path to rename the root path of the health probes ?

Thank you

rohanKanojia

rohanKanojia commented on Mar 7, 2025

@rohanKanojia
Member

@claudio4j : Would you be able to create a PR to update the documentation? Since you've recently worked with the enricher, I believe you're more familiar with its behavior. You can find it's source code here.

claudio4j

claudio4j commented on Mar 7, 2025

@claudio4j
Author

Sure, I'm glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @claudio4j@rohanKanojia

    Issue actions

      jkube-healthcheck-spring-boot enricher: rename property management.health.probes.enabled · Issue #3690 · eclipse-jkube/jkube