Skip to content

SYCL: use 1D kernel for set_rows #14618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

qnixsynapse
Copy link
Collaborator

Continue from #14562

Got it at the same level of performance as the cpy kernel

Model Batch size Test t/s master t/s sycl/set_rows_1d_kernel Speedup
llama 3B F16 64 pp1024 770.33 849.79 1.10
llama 3B F16 128 pp1024 1196.16 1412.73 1.18
llama 3B F16 256 pp1024 1823.87 2341.93 1.28
llama 3B F16 512 pp1024 2586.44 3224.97 1.25
llama 3B F16 1024 pp1024 2602.06 3244.33 1.25
llama 3B F16 2048 pp512 2648.21 3346.26 1.26
llama 3B F16 2048 tg128 23.99 25.31 1.06

With LLAMA_SET_ROWS=0

model size params backend ngl n_batch test t/s
llama 3B F16 5.98 GiB 3.21 B SYCL 99 64 pp1024 846.00 ± 1.63
llama 3B F16 5.98 GiB 3.21 B SYCL 99 128 pp1024 1409.40 ± 3.23
llama 3B F16 5.98 GiB 3.21 B SYCL 99 256 pp1024 2346.72 ± 1.56
llama 3B F16 5.98 GiB 3.21 B SYCL 99 512 pp1024 3226.67 ± 3.88
llama 3B F16 5.98 GiB 3.21 B SYCL 99 1024 pp1024 3253.42 ± 5.65
llama 3B F16 5.98 GiB 3.21 B SYCL 99 tg128 tg128 25.49 ± 0.07

Thanks @AD2605

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants