[refactor] Flux single file implementation #11881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DN6
reviewed
Jul 8, 2025
| @@ -1244,31 +1244,21 @@ class FluxPosEmbed(nn.Module): | |||
| # modified from https://github.com/black-forest-labs/flux/blob/c00d7c60b085fce8058b9df845e036090873f2ce/src/flux/modules/layers.py#L11 | |||
| def __init__(self, theta: int, axes_dim: List[int]): | |||
| super().__init__() | |||
|
|
|||
There was a problem hiding this comment.
Think here you can patch __new__ with the correct import and return the new object. Similar to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question: should we remove all intermediate imports of norm/embed layers, implement within the file, and make the entire implementation truly single file?
The minimal flux inference code does not run yet. The code from upstream branch is not fully completed and type hints are done with classes that don't exist.