Switch to use A10 progressively #38936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jun 20, 2025
Comment on lines
-15
to
-16
| runner: | ||
| required: true |
There was a problem hiding this comment.
we don't this. It was there in old time maybe.
ydshieh
commented
Jun 20, 2025
| @@ -45,7 +45,7 @@ jobs: | |||
| matrix: | |||
| folders: ${{ fromJson(inputs.folder_slices)[inputs.slice_id] }} | |||
| runs-on: | |||
| group: '${{ inputs.machine_type }}' | |||
| group: ${{ fromJson(inputs.runner_map)[matrix.folders][inputs.machine_type] }} | |||
There was a problem hiding this comment.
see the newly added get_runner_map.py
ydshieh
commented
Jun 20, 2025
.github/workflows/model_jobs_amd.yml
Outdated
ydshieh
commented
Jun 20, 2025
| @@ -51,7 +51,6 @@ jobs: | |||
| with: | |||
| job: run_models_gpu | |||
| slack_report_channel: "#transformers-ci-daily-models" | |||
| runner: daily-ci | |||
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Will merge once I trigger a run with A10 and update https://huggingface.co/datasets/hf-internal-testing/transformers_daily_ci/blob/main/runner_map.json thank you |
ydshieh
force-pushed
the
allow_ci_to_use_a10_clean
branch
from
20a05d6 to
63736a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I don't want to switch in one go. My goal is to switch those job to use A10 if they have no extra failures on A10 compared to T4.
For those have extra failures on A10, I will fix them and switch to A10 progressively.
Currently, the data fetched is from
https://huggingface.co/datasets/hf-internal-testing/transformers_daily_ci/blob/main/runner_map.json
I will trigger manually a run with A10 and fill the model names (that should use T4 runners) to the above file.