Skip to content

Commit 43df829

Browse files
committed
code review feedback: reduce scope of the 'unchecked cast' warning fix a.k.a. @SuppressWarnings('unchecked')
1 parent 45be4ae commit 43df829

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/main/java/org/junit/runners/model/FrameworkMember.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ public abstract class FrameworkMember<T extends FrameworkMember<T>> implements
1212
Annotatable {
1313
abstract boolean isShadowedBy(T otherMember);
1414

15-
@SuppressWarnings("unchecked")
1615
T handlePossibleBridgeMethod(List<T> members) {
1716
for (int i = members.size() - 1; i >=0; i--) {
1817
T otherMember = members.get(i);
@@ -31,7 +30,11 @@ T handlePossibleBridgeMethod(List<T> members) {
3130
}
3231
}
3332
// No shadow or bridge method found. The caller should add *this* member.
34-
return (T) this;
33+
FrameworkMember<? extends T> thisMember = this;
34+
@SuppressWarnings("unchecked")
35+
T result = (T) thisMember;
36+
37+
return result;
3538
}
3639

3740
abstract boolean isBridgeMethod();

0 commit comments

Comments
 (0)