Replacement API for Hamcrest methods in ExpectedException and ErrorCollector

[marcphilipp]

We need to decide if we need replacement APIs for the methods that take Hamcrest matchers as parameters.

The discussion has started in #1150.

[kcooney]

Most users shouldn't use ExpectedException (unless they cannot use lambdas).

The best way to replace the methods in ErrorCollector is to allow the caller so specify a Predicate, but that requires JDK 1.8.

Removing Hamcrest APIs would break backwards compatibility, so I don't see a reason to fix this in 4.13. Removing this from the 4.13 milestone.

[junit-builds]

JUnit 4 is now in maintenance mode.

At this point, only critical bugs and security issues will be fixed.

The team has therefore decided to close this issue.