Depending tests

[lstrzelecki]

I want create One test which should be run at begining. Then should run or not other dependent test.

Real example.
Want create test which starts spring context. When its green than it run all tests which try crerate spring context. If this test will fail. Than rest of test shouldn't be invoked.

Currntly when you have multiple tests with spring. All test try to create spring in each test. And it take ages.

I dont wont to use some configuration in maven/gradle plugins.

THIS feature request is NOT for creating tests which use same data. Each test should be independent.

[dsaff]

This is doable with the current implementation. Create something like this:

class SpringContextFactory {
  public static SpringContextFactory INSTANCE = new SpringContextFactory();

  private boolean mCreationFailed = false;

  public SpringContext createOrFail() {
    if (mCreationFailed) {
      fail();
    }
    try {
      return create();
    } catch (CouldNotCreateException e) {
      mCreationFailed = true;
      fail();
    }
  }

  public SpringContext createOrSkip() {
    try {
      createOrFail();
    } catch (AssertionError e) {
      throw new AssumptionFailedException();
    }
  }

  private SpringContext create() throws CouldNotCreateException {
    // do real creation or throw CouldNotCreateException ...
  }
}

Then, in your tests:

public class FooTest {
  @Test public void canCreateContext() {
    SpringContextFactory.INSTANCE.createOrFail();
  }

  @Test public void useContextIfPossible() {
    SpringContext context = SpringContextFactory.INSTANCE.createOrSkip();
    // use context
  }
}

We could work into JUnit something like ShortCircuitResourceFactory that would make it easier to build something like SpringContextFactory: would that help?

[lstrzelecki]

I don't want place this line in each test. I want clean //given //when //then blocks in Unittests

I've created draft of project and described problem in README.md

https://github.com/lstrzelecki-issues/junit-dependent-tests

[artkoshelev]

wouldn't assume solve your problem?

//given
assumeThat(context, isCreated());
...

[lstrzelecki]

not really.

1. Tests are running in multithread. But i want to know that App.class context is vali. But dont know when it will be runned.
2. I have one test for whole application.
3. Rest of test have subgroup of App test.

Feel free to update project in which I exposed problem:
https://github.com/lstrzelecki-issues/junit-dependent-tests

[dsaff]

@lstrzelecki, referring back to your comment three blocks up:

You have to get a SpringContext from somewhere in order to use it. In the place where you do this, retrieve it with SpringContextFactory.INSTANCE.createOrSkip(), and it should Just Work.

If you can't do this because of magic injection by Spring's test runner, you might want to ask the Spring team if they can enable behavior like this in their runner.

[lstrzelecki]

I've created example with my problem.
So in LoginServiceTest or RegisterServiceTest I should have SpringContextFactory.INSTANCE.createOrSkip() with which part of Context? For whole application? If that so.

1. When I want run test for functionality (i.e. Logging in my example) I should create whole Context for whole application (it takes time if application is bigger)
2. Solution SpringContextFactory.INSTANCE.createOrSkip() solves problem with multiple failing tests when whole app is wrong configured. But it doesn't give me quick tests. Because when you want run one test or group test for one functionality you always create whole context for whole application right (even you don't want to)?

[lstrzelecki]

I have two main scenarios for testing.

1. Run all tests, And then I don't want have multiple failing tests, when tests try to create context again & again...
2. Run one test or group for functionality. When you have implemented some feature or fixed bug. You need fast feedback for you area of work. When you don't changed other areas of application you want check all of them. Just check your area.

Main rule of tests is that it should be fast

[dsaff]

@lstrzelecki, I'm worried that there's some part of your configuration I'm not understanding.

I'm thinking that maybe you're saying that there are different Contexts being created by different tests, but there's a particular test, which, if it can't create it's own Context, no test that creates any Context will be useful?

[junit-builds]

JUnit 4 is now in maintenance mode.

At this point, only critical bugs and security issues will be fixed.

The team has therefore decided to close this issue.