Thread created with FailOnTimeout should be named sometime more useful than "Thread-#"

[mkw]

When debugging or profiling highly threaded tests, leaving the JUnit timeout threads as "Thread-#" is not very useful.

The obvious name for threads would probably be the full name for the test. This could be passed in from both BlockJUnit4ClassRunner#withPotentialTimeout, which has access to the Method object, and Timeout#apply, which has access to the Description object.

The fix for #657 names these threads "Time-limited test," which somewhat more useful, but still ambiguous when a large number of tests are run.

[kcooney]

Feel free to submit a pull request that gives the threads better names. I am not sure why you would need the test name in the thread unless you are running tests in parallel, but I don't do much profiling

[mkw]

I'll create a pull request as soon as I get a chance. The biggest reason that this is useful is that I sometimes use periodic memory dumps to find leaks. When looking at the dump in the profiler, the stack trace for each thread is available, but buried when many threads are active. The name of the thread is summarized in a clean list. If the thread was named with the test, it would be trivial to glance at what threads are in what states and immediately have an idea of which test or tests were running.

[cfontes]

Maybe something like this #980?

[modocache]

An attempt to address this issue is being made in #1117 ☝️

[adrianosimoes]

The pull request originated from this issue was closed. Should this issue also be closed?

[kcooney]

@adrianosimoes the pull was closed because of unresolved comments, not because we wouldn't want this feature.

[junit-builds]

JUnit 4 is now in maintenance mode.

At this point, only critical bugs and security issues will be fixed.

The team has therefore decided to close this issue.