Replace univocity-parsers with FastCSV #4606

vdmitrienko · 2025-06-01T18:53:48Z

Overview

#4339

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in Release Notes

marcphilipp

This looks very promising! 👍

gradle/libs.versions.toml

junit-jupiter-params/junit-jupiter-params.gradle.kts

...ooling-support-tests/src/test/java/platform/tooling/support/tests/ModularUserGuideTests.java

platform-tooling-support-tests/platform-tooling-support-tests.gradle.kts

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvArgumentsProvider.java

jupiter-tests/jupiter-tests.gradle.kts

junit-jupiter-params/LICENSE-fastcsv.md

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvReaderFactory.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvArgumentsProvider.java

…-parsers-with-fastcsv # Conflicts: # junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvArgumentsProvider.java

osiegmar · 2025-06-22T14:26:33Z

FastCSV 4.0.0 has just been released: https://github.com/osiegmar/FastCSV/releases/tag/v4.0.0

marcphilipp · 2025-06-22T15:23:40Z

@osiegmar Thank you!

@vdmitrienko I'd like to merge this PR before releasing 6.0.0-M1. Do you have time to continue working on it in the next few days? Please let me know if you're waiting on a decision or anything else.

…-parsers-with-fastcsv

vdmitrienko · 2025-06-22T15:47:00Z

@osiegmar Thank you!

@vdmitrienko I'd like to merge this PR before releasing 6.0.0-M1. Do you have time to continue working on it in the next few days? Please let me know if you're waiting on a decision or anything else.

@marcphilipp, yep I'm working on it right now and plan to finalize it in the next couple of hours 🙂

…y-parsers-with-fastcsv' into junit-team#4339-replace-univocity-parsers-with-fastcsv

vdmitrienko · 2025-06-22T19:07:46Z

Well, I think everything is ready to hand over this branch to you, @marcphilipp 🙂

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc

marcphilipp

@vdmitrienko Thanks for all the hard work! 👍

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc

gradle/libs.versions.toml

vdmitrienko added 15 commits June 1, 2025 20:46

Remove univocity-parsers license

6287630

Do not create a shadow jar from com.univocity

7d98380

Rework arguments providers to use FastCSV

aabcd60

test: Update expected root cause exceptions

fd33e6f

test: Update expected message on empty CSV

1dc063f

test: Cover additional cases for empty values

b8efe07

Move "either value or textBlock" validation to getData(CsvSource)

f62814c

Deprecate CsvFileSource.lineSeparator as it's now detected automatically

e768e7a

test: Remove CsvFileSource.lineSeparator() usages

72ae172

CsvReaderFactory: set "since" to 6.0

c96e787

Preserve the original validation order

3d3cadf

Formatting

b88e12d

ModularUserGuideTests: require de.siegmar.fastcsv module

cc7fd8c

platform-tooling-support-tests: add FastCSV dependency

ff2691c

Add release notes

Loading
Loading status checks…

cd3cc0e

vdmitrienko mentioned this pull request Jun 1, 2025

Replace univocity-parsers with FastCSV #4339

Closed

1 task

marcphilipp reviewed Jun 2, 2025

View reviewed changes

test: use CsvParseException import instead of a fully qualified name

4eaba09

rolnico mentioned this pull request Jun 3, 2025

Replace univocity-parsers with FastCSV powsybl/powsybl-core#3463

Open

vdmitrienko added 5 commits June 3, 2025 19:20

Use condition() instead of creating PreconditionViolationException

7661c96

Respect alphabetical order in libs.versions.toml

59effbb

Shadow FastCSV

bfe368c

Remove the no longer used extraJavaModuleInfo plugin

b913ee3

Updates according to the recent changes in FastCSV snapshot

61350e4

vdmitrienko requested a review from osiegmar June 5, 2025 20:16

osiegmar reviewed Jun 6, 2025

View reviewed changes

vdmitrienko added 4 commits June 7, 2025 15:54

Merge branch 'refs/heads/main' into junit-team#4339-replace-univocity…

0de1857

…-parsers-with-fastcsv # Conflicts: # junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvArgumentsProvider.java

Avoid calling getFields() to prevent unnecessary object creation

43cd5c6

Remove univocity.parsers module option from documentation.gradle.kts

50acf31

Set allowDuplicateHeaderFields explicitly to avoid relying on defaults

e2ac4f4

Minor polishing

Loading
Loading status checks…

3f74e33

marcphilipp added component: Jupiter theme: parameterized tests labels Jun 22, 2025

vdmitrienko and others added 3 commits June 22, 2025 17:42

Remove lineSeparator() since FastCSV detects it automatically

ea07055

Merge branch 'refs/heads/main' into junit-team#4339-replace-univocity…

05277d5

…-parsers-with-fastcsv

Use Gradle task to extract FastCSV license

Loading
Loading status checks…

28df2ee

vdmitrienko and others added 4 commits June 22, 2025 17:49

Merge remote-tracking branch 'origin/junit-team#4339-replace-univocit…

Loading
Loading status checks…

91c69b2

…y-parsers-with-fastcsv' into junit-team#4339-replace-univocity-parsers-with-fastcsv

Only include FastCSV license once

Loading
Loading status checks…

e4bcdd0

Replace locally built FastCSV snapshot with officially released version

696bde6

Merge remote-tracking branch 'origin/junit-team#4339-replace-univocit…

Loading
Loading status checks…

0f95d7f

…y-parsers-with-fastcsv' into junit-team#4339-replace-univocity-parsers-with-fastcsv

vdmitrienko marked this pull request as ready for review June 22, 2025 16:21

vdmitrienko added 3 commits June 22, 2025 18:21

Polish release notes

63211eb

documentation: add reads for de.siegmar.fastcsv module

Loading
Loading status checks…

ac81c55

Add module declaration

Loading
Loading status checks…

d786894

marcphilipp added 2 commits June 23, 2025 09:43

Polish license handling

Loading
Loading status checks…

328706a

Include fastcsv license in junit-platform-console-standalone jar

Loading
Loading status checks…

4044fd9

marcphilipp reviewed Jun 23, 2025

View reviewed changes

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc Outdated Show resolved Hide resolved

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc Outdated Show resolved Hide resolved

marcphilipp added 2 commits June 23, 2025 11:05

Restore configuration cache compatibility

Loading
Loading status checks…

bb7aaa8

Restore validation of non-blankness of strings in @CsvSource(value)

Loading
Loading status checks…

053b031

marcphilipp approved these changes Jun 23, 2025

View reviewed changes

Polish release notes

Loading
Loading status checks…

c1858d7

marcphilipp linked an issue Jun 23, 2025 that may be closed by this pull request

Replace univocity-parsers with FastCSV #4339

Closed

1 task

sormuras reviewed Jun 23, 2025

View reviewed changes

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0-M1.adoc Outdated Show resolved Hide resolved

sormuras reviewed Jun 23, 2025

View reviewed changes

gradle/libs.versions.toml Show resolved Hide resolved

Polishing

Loading
Loading status checks…

9aab4b5

marcphilipp merged commit 8f002e9 into junit-team:main Jun 23, 2025
13 checks passed

Replace univocity-parsers with FastCSV #4606

Replace univocity-parsers with FastCSV #4606

Conversation

vdmitrienko commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Definition of Done

Uh oh!

Uh oh!

marcphilipp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

osiegmar commented Jun 22, 2025

Uh oh!

marcphilipp commented Jun 22, 2025

Uh oh!

Uh oh!

vdmitrienko commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vdmitrienko commented Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcphilipp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vdmitrienko commented Jun 1, 2025 •

edited

Loading

vdmitrienko commented Jun 22, 2025 •

edited

Loading