Avoid reporting discovery warnings for abstract methods #4668
+26
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
marc/4636-no-discovery-issues-for-abstract-methods
branch
from
d69ceec to
1b9875b
Compare
| method.toGenericString()); | ||
| assertThat(discoveryIssues.getLast().message()) // | ||
| var issue = getOnlyElement(discoveryIssues); | ||
| assertThat(issue.message()) // |
There was a problem hiding this comment.
In some, much more than I like, cases like this, yes. It's due to a limitation of the underlying code formatter being used: spotless
There was a problem hiding this comment.
To be precise, Spotless is not to blame but the Eclipse JDT formatter we have configured it to use.
sormuras
approved these changes
Jun 24, 2025
marcphilipp
force-pushed
the
marc/4636-no-discovery-issues-for-abstract-methods
branch
from
1b9875b to
b4a9bad
Compare
marcphilipp
force-pushed
the
marc/4636-no-discovery-issues-for-abstract-methods
branch
from
b4a9bad to
9be3b20
Compare
marcphilipp
deleted the
marc/4636-no-discovery-issues-for-abstract-methods
branch
marcphilipp
added a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #4636.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations