Skip to content

Refactor CLI API #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 24, 2025
Merged

Refactor CLI API #1924

merged 15 commits into from
Jun 24, 2025

Conversation

xiaoyu-work
Copy link
Contributor

Describe your changes

  1. CLI - APIs now shares a unified entrypoint. Any future CLI can be easily added as an API.
  2. Remove duplicated olive.run from cli api file.
  3. Add a real integ test to test file.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link
Contributor

@shaahji shaahji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session_params_tuning.py also needs to be updated to return the workflow output.

shaahji
shaahji previously approved these changes Jun 23, 2025
@xiaoyu-work
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@xiaoyu-work xiaoyu-work merged commit 2b786ea into main Jun 24, 2025
21 checks passed
@xiaoyu-work xiaoyu-work deleted the api branch June 24, 2025 21:43
@xiaoyu-work xiaoyu-work restored the api branch June 27, 2025 00:25
@xiaoyu-work xiaoyu-work deleted the api branch July 16, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants