Skip to content

add golint to ci pipeline #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add golint to ci pipeline #219

wants to merge 1 commit into from

Conversation

hgarvison
Copy link
Contributor

add golint to ci pipeline and update to go version 1.24.4

Copilot

This comment was marked as outdated.

@hgarvison hgarvison force-pushed the go_lint branch 2 times, most recently from 1cadc8e to 8f4825c Compare June 20, 2025 16:17
@hgarvison hgarvison requested a review from Copilot June 20, 2025 19:08
Copilot

This comment was marked as resolved.

@stevendongatmsft
Copy link
Contributor

Are CodeQL and Trivy supposed to have that configuration not found next to it?

@hgarvison
Copy link
Contributor Author

Are CodeQL and Trivy supposed to have that configuration not found next to it?

@stevendongatmsft Ideally no. This is happening because of the intermittent ACI failures in eastus2euap that causes our nightly pipeline run to fail sometimes.

@stevendongatmsft
Copy link
Contributor

I noticed a lot of changes such as exchanging return variable sequence. For example _, variable -> variable, nil. Did uou manually change these based on the findings of linter?

@hgarvison
Copy link
Contributor Author

I noticed a lot of changes such as exchanging return variable sequence. For example _, variable -> variable, nil. Did uou manually change these based on the findings of linter?

@stevendongatmsft yes

Copy link
Contributor

@stevendongatmsft stevendongatmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants