Skip to content

issues Search Results · repo:microsoft/confidential-sidecar-containers language:Go

Filter by

30 results
 (92 ms)

30 results

inmicrosoft/confidential-sidecar-containers (press backspace or delete to remove)

microsoft/confidential-sidecar-containers
CommittedSvn, CommittedVersion, and LaunchSvn are not serialized in SerializeReport

The method SerializeReport() does not serialize the described fields, causing an error when the signature is checked: https://github.com/microsoft/confidential-sidecar-containers/blob/e3e00a1a216a8087a71183f97bae1a1fab9adde2/pkg/attest/snp_attestation_report.go#L107 ...
  • johannww
  • Opened 
    on Jun 3
  • #213

microsoft/confidential-sidecar-containers
Add image attached fragments example

  • hgarvison
  • 2
  • Opened 
    on May 22
  • #210

microsoft/confidential-sidecar-containers
Update c-aci-testing version

Currently at 1.0.6 but latest is 1.2.2.
  • KenGordon
  • 3
  • Opened 
    on May 8
  • #205

microsoft/confidential-sidecar-containers
CRLF pollution

especially in common/*.go
  • KenGordon
  • 1
  • Opened 
    on May 8
  • #203

microsoft/confidential-sidecar-containers
Improve the fetching of certs as fallback case for stale certs vs actual report

While some code paths do retries to make sure the TCB for a report matches the certs, not all do. For endpoints such as attest/combined we should make sure of this.
  • KenGordon
  • Opened 
    on May 8
  • #202

microsoft/confidential-sidecar-containers
Milan vs Genoa when asking AMD for certs.

pkg/attest/platform_cert_fetcher.go asks specifically for Milan certs when reaching out to AMD. This ought to be tested on a Genoa machine to see if it works and then perhaps update the code to use /proc/cpuinfo ...
  • KenGordon
  • Opened 
    on May 8
  • #201

microsoft/confidential-sidecar-containers
StatusForbidden vs StatusInternalServerError

In internal/httpginendpoints/httpginendpoints.go review returning StatusForbidden in various places where some checking (eg when some base64 decode has failed) - surely should be StatusInternalServerError? ...
  • KenGordon
  • Opened 
    on May 8
  • #200

microsoft/confidential-sidecar-containers
Remove duplicate helper: DirectWrap vs directWrap

pkg/grpc/grpcserver/server.go (same file that defines WrapKey) contains two functions that do identical RSA-3072 wrapping: func directWrap(...) // unexported, called once inside WrapKey func DirectWrap(...) ...
  • ksayid
  • 2
  • Opened 
    on Apr 30
  • #192

microsoft/confidential-sidecar-containers
Support of confidential containers with AKS and confidential VMs

It looks like it s not possible to use the attestation-container with Confidential Containers with AKS or Contidential VMs with AMD SEV-SNP. With confidential VMs, the design of the attestation does not ...
wontfix
  • grydz
  • 3
  • Opened 
    on Mar 7
  • #177

microsoft/confidential-sidecar-containers
Why are not the fields committed_svn, committed_version, launch_svn printed on the verbose report?

We can see that they are not included on the output. Is there a reason for that? They would be useful when attesting against the AMD certificate chain. (amd sev-snp ATTESTATION_REPORT specs) https://github.com/microsoft/confidential-sidecar-containers/blob/dacb238505c5ec3278e771c4c05a8e3e34d7afc0/tools/get-snp-report/helpers.c#L67-L89 ...
  • johannww
  • 1
  • Opened 
    on Mar 2
  • #175
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub