Add .gitattributes to enforce LF line endings for shell scripts #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to Docker client handling for better platform compatibility, adds SSL support to the
ui
command, and ensures consistent line endings for shell scripts. Below are the most significant changes:Docker client handling improvements:
get_docker_client
function insrc/magentic_ui/_docker.py
to handle platform-specific Docker client initialization, particularly for Windows environments.docker.from_env()
withget_docker_client()
across multiple functions, includingcheck_docker_running
,build_browser_image
,build_python_image
,check_browser_image
, andcheck_python_image
. This ensures consistent Docker client initialization. [1] [2] [3] [4]SSL support for
ui
command:ssl_certfile
andssl_keyfile
parameters to theui
command insrc/magentic_ui/backend/cli.py
, enabling optional SSL configuration. [1] [2]uvicorn.run
call to conditionally include SSL certificate and key file paths if provided, ensuring secure HTTPS support. [1] [2]Miscellaneous:
.gitattributes
to enforce LF line endings for all.sh
files, ensuring consistent behavior across platforms.This pull request includes a small change to the.gitattributes
file. The change ensures that all.sh
files will have line endings normalized to LF (eol=lf
).