Add/ckg2 rm #3261
Merged
Add/ckg2 rm #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2025 17:11
With images I was able to rip from amazon product listing.
more concise
Powered Device (passthrough...)
There was a problem hiding this comment.
Pull Request Overview
Add a new device type YAML for the Ubiquiti CloudKey Gen2 rack mount adapter, capturing metadata and physical specs.
- Introduce metadata (manufacturer, model, slug, part_number)
- Define physical attributes (u_height, weight, airflow, imaging flags)
- Add subdevice role and interface section
Comments suppressed due to low confidence (3)
device-types/Ubiquiti/CKG2-RM.yaml:22
- The rack mount adapter is a passive mechanical accessory and does not have network interfaces. The
interfacessection should be removed to avoid incorrectly modeling an eth0 port.
interfaces:
device-types/Ubiquiti/CKG2-RM.yaml:17
- [nitpick] Remove or resolve the comment block expressing uncertainty around subdevice modeling before merging. If needed, document the final approach in official docs rather than leaving TODO-style comments.
# This is always a parent device. When standalone, the cloud key is technically is not a parent or child.
device-types/Ubiquiti/CKG2-RM.yaml:3
- [nitpick] The model name should reflect Gen2 compatibility per the PR description. Consider renaming to
CloudKey Gen2 Rack Mountfor clarity.
model: CloudKey Rack Mount
harryajc
requested changes
Jun 20, 2025
harryajc
added
the
status: revisions needed
harryajc
requested changes
Jun 23, 2025
harryajc
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rack mount adapter for cloud key gen2 devices