Initial commit of TESmart kvm #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did my best to crop marketing images
There was a problem hiding this comment.
Pull Request Overview
Initial commit adds a device definition for the TESmart HKS801-P23-USBK KVM switch, including metadata, physical specs, and port configurations.
- Introduces
HKS801-P23-USBK.yamlwith manufacturer, model, slug, part number, and descriptive comments. - Specifies power, console, and console-server port mappings.
- Notes omission of IR port due to lack of presence evidence.
Comments suppressed due to low confidence (2)
device-types/TESmart/HKS801-P23-USBK.yaml:21
- Consider adding a unit (e.g.,
maximum_draw_unit: A) or annotating the value to clarify that this is in amperes.
maximum_draw: 1
device-types/TESmart/HKS801-P23-USBK.yaml:42
- [nitpick] Port name includes a slash which may conflict with lookup keys; consider using a simpler identifier like
kvm-1.
- name: KVM/1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
`precedent` is what I meant...
_sigh_
with the `mgmt_only` flag set.
…add/tesmart-HKS801-P23-USBK
Properly classify the type of LAN interface
harryajc
approved these changes
Jun 26, 2025
fspijkerman
pushed a commit
to leafcloudhq/devicetype-library
that referenced
this pull request
Jul 11, 2025
* Initial commit of TESmart kvm did my best to crop marketing images * Update device-types/TESmart/HKS801-P23-USBK.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * nit / typo fix `precedent` is what I meant... * lint `"` -> `'` _sigh_ * better classify the LAN port as an interface with the `mgmt_only` flag set. * oops, forgot th dangling `x` Properly classify the type of LAN interface --------- Co-authored-by: Karl Quinsland <contact@kquinsland.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did my best to crop marketing images