Fix for duplicate uniq_agents #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivar-lazzaro
suggested changes
Jul 26, 2018
| @@ -48,7 +48,7 @@ def upgrade(): | |||
| sa.Column('version', sa.String(10)), | |||
| sa.PrimaryKeyConstraint('id'), | |||
| sa.UniqueConstraint('agent_type', 'host', | |||
| name='uniq_agents0agent_type0host')) | |||
| name='aim_agents_uniq_agents0agent_type0host')) | |||
There was a problem hiding this comment.
Changing an existing migration file is not gonna work, as this code won't run on systems that already have AIM installed.
Please revert this file, and create a new migration HEAD that modifies the existing constraint name.
If this makes it impossible to install AIM in any particular system, then keep this file modified. But also add a new HEAD which checks the constraint name and fixes it if required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names uniq_agents0agent_type0host conflicts with the unique values created by neutron db schema. This conflict throws errors due to the uniqueness constraint. This commit fixes the unique name constraint with a separate name for aim_agents.