[Camera] Re-enable WebRTC Requester tests #40134
Merged
+176
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request re-enables WebRTC requester tests by introducing a new establish-session command that correctly allocates a video stream before initiating the WebRTC session. The changes look good and logically follow the PR's objective.
I've made a few suggestions:
- Critical: Remove hardcoded user-specific paths from the new VSCode configuration files to ensure they are portable for all developers.
- Medium: Refactor duplicated code into a helper function for better maintainability.
- Medium: Replace a magic number with a
static_castto an enum for better readability and type safety.
examples/camera-controller/commands/webrtc/WebRTCProviderCommands.cpp
Outdated
Show resolved
Hide resolved
yufengwangca
force-pushed
the
pr/webrtcr/test
branch
from
2425a6f to
aa3893b
Compare
…nds.cpp Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #40134: Size comparison from b7bbf2e to e91755b Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marktrayer
approved these changes
Jul 16, 2025
chulspro
approved these changes
Jul 16, 2025
joonhaengHeo
approved these changes
Jul 17, 2025
miduggan24
pushed a commit
to miduggan24/connectedhomeip
that referenced
this pull request
Jul 17, 2025
* Re-enable WebRTC Requster tests * Update examples/camera-controller/commands/webrtc/WebRTCProviderCommands.cpp Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WebRTC Requester tests has been temperately disabled due to the camera-controller could not allocate video stream before establishing WebRTC session.
Related issues
Fixes: #39840
Testing
Update the WebRTCR python tests and validate the change by CI