Skip to content

Commit dade8cd

Browse files
committed
Fix "Store reports" steps condition to actually run when build fails
Conditions need to call one of the status check functions to overwrite the default success().
1 parent 54e5106 commit dade8cd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/maven.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
run: mvn -B -U -ntp verify --fail-at-end
3737

3838
- name: Store reports
39-
if: steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure'
39+
if: always() && (steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure')
4040
uses: actions/upload-artifact@v3
4141
with:
4242
name: linux-reports
@@ -67,7 +67,7 @@ jobs:
6767
run: mvn -B -U -ntp verify --fail-at-end
6868

6969
- name: Store reports
70-
if: steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure'
70+
if: always() && (steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure')
7171
uses: actions/upload-artifact@v3
7272
with:
7373
name: windows-reports
@@ -105,7 +105,7 @@ jobs:
105105
run: mvn -B -U -ntp verify --fail-at-end "-Dinvoker.javaHome=$JAVA_HOME_${{ matrix.java }}_X64"
106106

107107
- name: Store reports
108-
if: steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure'
108+
if: always() && (steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure')
109109
uses: actions/upload-artifact@v3
110110
with:
111111
name: jdk-${{ matrix.java }}-reports
@@ -147,7 +147,7 @@ jobs:
147147
run: mvn -B -U -ntp verify --fail-at-end -DgwtVersion=${{ matrix.gwt }} -DgwtGroupId=${{ matrix.groupId }}
148148

149149
- name: Store reports
150-
if: steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure'
150+
if: always() && (steps.maven-build.outcome == 'success' || steps.maven-build.outcome == 'failure')
151151
uses: actions/upload-artifact@v3
152152
with:
153153
name: gwt-${{ matrix.gwt }}-reports

0 commit comments

Comments
 (0)