Upgrade JDT to 3.8.3.

Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Review-Link: https://gwt-review.googlesource.com/#/c/2361/


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@11610 8db76d5a-ed1c-0410-87a9-c151d255dfc7

Author: rluble@google.com

dev/build.xml

@@ -56,7 +56,8 @@
         <fileset dir="${gwt.tools.lib}">
           <include name="apache/tapestry-util-text-4.0.2.jar" />
           <include name="apache/ant-1.6.5.jar" />
-          <include name="eclipse/jdt-3.4.2_r894.jar" />
+          <include name="eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar" />
+          <include name="eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar" />
           <include name="guava/guava-10.0.1/guava-10.0.1-rebased.jar" />
           <include name="jscomp/r1649/compiler-rebased.jar" />
           <include name="jetty/jetty-6.1.11.jar" />
@@ -105,7 +106,8 @@
         <gwt.jar destfile="${alldeps.jar}">
           <zipfileset src="${gwt.tools.lib}/apache/tapestry-util-text-4.0.2.jar" />
           <zipfileset src="${gwt.tools.lib}/apache/ant-1.6.5.jar" />
-          <zipfileset src="${gwt.tools.lib}/eclipse/jdt-3.4.2_r894.jar" />
+          <zipfileset src="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar" />
+          <zipfileset src="${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar" />
           <zipfileset src="${gwt.tools.lib}/guava/guava-10.0.1/guava-10.0.1-rebased.jar" />
           <zipfileset src="${gwt.tools.lib}/jscomp/r1649/compiler-rebased.jar" />
           <zipfileset src="${gwt.tools.lib}/jetty/jetty-6.1.11.jar" />
@@ -180,7 +182,8 @@
       <include name="org/eclipse/jdt/**"/>
       <classpath>
           <pathelement location="${gwt.tools.lib}/apache/ant-1.6.5.jar" />
-          <pathelement location="${gwt.tools.lib}/eclipse/jdt-3.4.2_r894.jar" />
+          <pathelement location="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar" />
+          <pathelement location="${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar" />
           <pathelement location="${gwt.tools.lib}/apache/commons/commons-collections-3.2.1.jar" />
           <pathelement location="${gwt.tools.lib}/guava/guava-10.0.1/guava-10.0.1-rebased.jar" />
           <pathelement location="${gwt.tools.lib}/jscomp/r1649/compiler-rebased.jar" />

dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java

@@ -178,10 +178,11 @@ private static TypeDeclaration findType(TypeDeclaration[] types, char[] name) {
    * @return a CompilationUnitDeclaration or null if parsing failed
    */
   private static CompilationUnitDeclaration parseJava(String javaSource) {
-    CodeSnippetParsingUtil parsingUtil = new CodeSnippetParsingUtil();
+    CodeSnippetParsingUtil parsingUtil = new CodeSnippetParsingUtil(true);
     CompilerOptions options = new CompilerOptions();
-    options.complianceLevel = ClassFileConstants.JDK1_5;
-    options.sourceLevel = ClassFileConstants.JDK1_5;
+    options.complianceLevel = ClassFileConstants.JDK1_6;
+    options.originalSourceLevel = ClassFileConstants.JDK1_6;
+    options.sourceLevel = ClassFileConstants.JDK1_6;
     CompilationUnitDeclaration unit = parsingUtil.parseCompilationUnit(
         javaSource.toString().toCharArray(), options.getMap(), true);
     if (unit.compilationResult().hasProblems()) {

dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java

@@ -224,6 +224,11 @@ public char[][] getPackageName() {
       return CharOperation.splitOn('.', packageName.toCharArray());
     }
 
+    @Override
+    public boolean ignoreOptionalProblems() {
+      return false;
+    }
+
     @Override
     public String toString() {
       return builder.toString();
@@ -584,8 +589,13 @@ public static List<CompilationUnit> compile(TreeLogger logger,
   }
 
   public static CompilerOptions getCompilerOptions() {
-    CompilerOptions options = new CompilerOptions();
-    options.complianceLevel = options.sourceLevel = options.targetJDK = ClassFileConstants.JDK1_6;
+    CompilerOptions options = new CompilerOptions() {
+      {
+        warningThreshold.clearAll();
+      }
+    };
+    options.originalSourceLevel = options.complianceLevel = options.sourceLevel =
+        options.targetJDK = ClassFileConstants.JDK1_6;
 
     // Generate debug info for debugging the output.
     options.produceDebugAttributes =
@@ -599,7 +609,6 @@ public static CompilerOptions getCompilerOptions() {
     // Turn off all warnings, saves some memory / speed.
     options.reportUnusedDeclaredThrownExceptionIncludeDocCommentReference = false;
     options.reportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable = false;
-    options.warningThreshold = 0;
     options.inlineJsrBytecode = true;
     return options;
   }

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java

@@ -544,9 +544,6 @@ public void endVisit(CastExpression x, BlockScope scope) {
         SourceInfo info = makeSourceInfo(x);
         JType type = typeMap.get(x.resolvedType);
         JExpression expression = pop(x.expression);
-        if (x.type instanceof NameReference) {
-          pop(x.type);
-        }
         push(new JCastOperation(info, type, expression));
       } catch (Throwable e) {
         throw translateException(x, e);
@@ -3073,14 +3070,7 @@ private void createMembers(TypeDeclaration x) {
 
       if (x.fields != null) {
         for (FieldDeclaration field : x.fields) {
-          if (x.binding.isLocalType() && field.isStatic()) {
-            /*
-             * Source compatibility with genJavaAst; static fields in local
-             * types don't get visited.
-             */
-          } else {
-            createField(field);
-          }
+          createField(field);
         }
       }