Skip to content

Commit aae3114

Browse files
committed
change padding and call onResize when GeneViewer is displayed
1 parent d54ec37 commit aae3114

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

src/at/gmi/nordborglab/widgets/gwasgeneviewer/client/GWASGeneViewer.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,14 @@
2626
import com.google.gwt.uibinder.client.UiBinder;
2727
import com.google.gwt.user.client.ui.Composite;
2828
import com.google.gwt.user.client.ui.HTMLPanel;
29+
import com.google.gwt.user.client.ui.RequiresResize;
2930
import com.google.gwt.user.client.ui.Widget;
3031
import com.google.gwt.uibinder.client.UiField;
3132
import com.google.gwt.user.client.ui.Label;
3233
import com.google.gwt.visualization.client.DataTable;
3334
import com.google.gwt.visualization.client.Selection;
3435

35-
public class GWASGeneViewer extends Composite {
36+
public class GWASGeneViewer extends Composite implements RequiresResize{
3637

3738
private static ScatterGenomeChartUiBinder uiBinder = GWT
3839
.create(ScatterGenomeChartUiBinder.class);
@@ -69,7 +70,7 @@ interface ScatterGenomeChartUiBinder extends UiBinder<Widget, GWASGeneViewer> {
6970
//General settings
7071
protected String chromosome;
7172
protected int width = 1000;
72-
protected int geneViewerHeight = 200;
73+
protected int geneViewerHeight = 300;
7374
protected DataSource datasource = null;
7475
protected int viewStart = 0;
7576
protected int viewEnd = 0;
@@ -183,8 +184,8 @@ public void onZoom(ZoomEvent event) {
183184
{
184185
if (event.maxX - event.minX<= minZoomLevelForGenomeView)
185186
{
186-
geneViewer.updateZoom(event.minX, event.maxX);
187187
toggleGenomeViewVisible(true);
188+
geneViewer.updateZoom(event.minX, event.maxX);
188189
}
189190
else
190191
toggleGenomeViewVisible(false);
@@ -307,7 +308,12 @@ protected Options setOptions(Dygraphs.Options options){
307308

308309

309310
public void toggleGenomeViewVisible(boolean visible) {
310-
geneViewerContainer.setVisible(visible);
311+
//geneViewerContainer.setVisible(visible);
312+
geneViewer.setVisible(visible);
313+
if (visible) {
314+
geneViewer.setSize(width - DYGRAPHOFFSET, geneViewerHeight);
315+
geneViewer.onResize();
316+
}
311317
}
312318

313319
public void setMinZoomLevelForGenomeView(Integer minZoomLevelForGenomeView) {
@@ -405,4 +411,10 @@ public Selection getTopSNP() {
405411
return null;
406412
return getTopSNP(dataTable);
407413
}
414+
415+
@Override
416+
public void onResize() {
417+
geneViewer.onResize();
418+
scatterChart.onResize();
419+
}
408420
}

src/at/gmi/nordborglab/widgets/gwasgeneviewer/client/GWASGeneViewer.ui.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
xmlns:gview="urn:import:at.gmi.nordborglab.widgets.geneviewer.client">
66
<ui:style>
77
.genomeView {
8-
margin: 0px 5px 0px 26px;
8+
margin: 0px 5px 0px 0px;
99
}
1010
</ui:style>
1111
<g:FlowPanel height="100%" >
1212
<g:HTMLPanel>
1313
<g:Label horizontalAlignment="ALIGN_LEFT" ui:field="chromosome_label"/>
1414
</g:HTMLPanel>
1515
<dyg:Dygraphs ui:field="scatterChart"></dyg:Dygraphs>
16-
<g:HTMLPanel ui:field="geneViewerContainer" visible="false">
17-
<gview:GeneViewer ui:field="geneViewer" addStyleNames='{style.genomeView}'></gview:GeneViewer>
16+
<g:HTMLPanel ui:field="geneViewerContainer" visible="true">
17+
<gview:GeneViewer ui:field="geneViewer" visible="false" addStyleNames='{style.genomeView}'></gview:GeneViewer>
1818
</g:HTMLPanel>
1919
</g:FlowPanel>
2020
</ui:UiBinder>

0 commit comments

Comments
 (0)