Skip to content

Commit 1464a79

Browse files
committed
Updated to latest JSInterops
1 parent 6db5465 commit 1464a79

File tree

8 files changed

+34
-35
lines changed

8 files changed

+34
-35
lines changed

ldviewer-sample/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
<dependency>
4949
<groupId>com.google.gwt</groupId>
5050
<artifactId>gwt-dev</artifactId>
51-
<scope>provided</scope>
5251
</dependency>
5352
<dependency>
5453
<groupId>com.github.timeu.gwt-libs.ldviewer</groupId>

ldviewer-sample/src/main/java/sample/client/SampleEntryPoint.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ private void zoom(boolean isZoomIn) {
160160
}
161161

162162
private String getMsgFromDataPoint(LDDataPoint data) {
163-
return "x:" + data.getPosX() + ", y:" + data.getPosY() + ",r2:" + data.getR2();
163+
return "x:" + data.posX + ", y:" + data.posY + ",r2:" + data.r2;
164164
}
165165

166166
private void sinkEvents() {

ldviewer/src/main/java/com/github/timeu/gwtlibs/ldviewer/client/LDData.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package com.github.timeu.gwtlibs.ldviewer.client;
22

33

4-
import com.google.gwt.core.client.js.JsProperty;
5-
import com.google.gwt.core.client.js.JsType;
4+
import jsinterop.annotations.JsPackage;
5+
import jsinterop.annotations.JsProperty;
6+
import jsinterop.annotations.JsType;
67

7-
@JsType
8+
@JsType(isNative = true, namespace = JsPackage.GLOBAL,name="Object")
89
public interface LDData {
910

10-
@JsProperty int[] getPositions();
11+
@JsProperty
12+
int[] getPositions();
1113
@JsProperty float[][] getR2();
1214
@JsProperty int getStart();
1315
@JsProperty int getEnd();
Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
11
package com.github.timeu.gwtlibs.ldviewer.client;
22

33

4-
import com.google.gwt.core.client.js.JsProperty;
5-
import com.google.gwt.core.client.js.JsType;
4+
import jsinterop.annotations.JsOverlay;
5+
import jsinterop.annotations.JsPackage;
6+
import jsinterop.annotations.JsProperty;
7+
import jsinterop.annotations.JsType;
68

7-
@JsType
8-
public interface LDDataPoint {
9+
@JsType(isNative = true,namespace = JsPackage.GLOBAL,name="Object")
10+
public class LDDataPoint {
911

12+
public double r2;
1013

11-
@JsProperty double getR2();
14+
public int posX;
1215

13-
@JsProperty void setR2(double r2);
14-
15-
@JsProperty void setPosX(int posX);
16-
17-
@JsProperty int getPosX();
16+
public int posY;
1817

19-
@JsProperty int getPosY();
20-
21-
@JsProperty void setPosY(int posY);
22-
23-
int getR2Color(double threshold,int maxColor);
24-
18+
@JsOverlay
19+
public final int getR2Color(double threshold,int maxColor) {
20+
return (int)Math.round((1 - (r2 - threshold)/(1-threshold))*maxColor);
21+
}
2522
}

ldviewer/src/main/java/com/github/timeu/gwtlibs/ldviewer/client/LDViewerInstance.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
import com.google.gwt.core.client.JsArray;
66
import com.google.gwt.core.client.JsArrayInteger;
77
import com.google.gwt.core.client.JsArrayNumber;
8-
import com.google.gwt.core.client.js.JsType;
8+
import jsinterop.annotations.JsType;
99

1010
import java.util.List;
1111

1212
/**
1313
* Created by uemit.seren on 8/12/15.
1414
*/
15-
@JsType
15+
@JsType(isNative = true)
1616
interface LDViewerInstance extends ProcessingInstance {
1717

1818
void api_setSize(int width, boolean isDraw);

ldviewer/src/main/java/com/github/timeu/gwtlibs/ldviewer/client/event/EventCallback.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.github.timeu.gwtlibs.ldviewer.client.event;
22

3-
import com.google.gwt.core.client.js.JsFunction;
3+
4+
import jsinterop.annotations.JsFunction;
45

56
/**
67
* Created by uemit.seren on 8/11/15.

ldviewer/src/test/java/com/github/timeu/gwtlibs/ldviewer/client/LDViewerTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,11 @@ public void testAddUnHighlightHandler() {
223223

224224
private LDDataPoint[] getFakeHighlightedPoints() {
225225
LDDataPoint[] points = new LDDataPoint[1];
226-
LDDataPoint point1 = mock(LDDataPoint.class);
227-
given(point1.getPosX()).willReturn(1);
228-
given(point1.getPosY()).willReturn(2);
229-
given(point1.getR2()).willReturn(0.5);
230-
given(point1.getR2Color(anyDouble(),anyInt())).willReturn(1);
226+
LDDataPoint point1 = new LDDataPoint();
227+
point1.posX = 1;
228+
point1.posY = 2;
229+
point1.r2 = 0.5;
230+
points[0] = point1;
231231
return points;
232232
}
233233

pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
<plugin>
117117
<groupId>net.ltgt.gwt.maven</groupId>
118118
<artifactId>gwt-maven-plugin</artifactId>
119-
<version>1.0-rc-2</version>
119+
<version>1.0-rc-4</version>
120120
<extensions>true</extensions>
121121
<configuration>
122122
<devMode>false</devMode>
@@ -125,23 +125,23 @@
125125
<arg>-runStyle</arg>
126126
<arg>Manual:1</arg>
127127
<arg>-XjsInteropMode</arg>
128-
<arg>JS</arg>
128+
<arg>JS_RC</arg>
129129
</testArgs>
130130
<startupUrls>
131131
<startupUrl>ldviewersample/index.html</startupUrl>
132132
</startupUrls>
133133
<compilerArgs>
134134
<compilerArg>-XjsInteropMode</compilerArg>
135-
<compilerArg>JS</compilerArg>
135+
<compilerArg>JS_RC</compilerArg>
136136
</compilerArgs>
137137
<devmodeArgs>
138138
<arg>-XjsInteropMode</arg>
139-
<arg>JS</arg>
139+
<arg>JS_RC</arg>
140140
<devmodeArg>-incremental</devmodeArg>
141141
</devmodeArgs>
142142
<codeserverArgs>
143143
<arg>-XjsInteropMode</arg>
144-
<arg>JS</arg>
144+
<arg>JS_RC</arg>
145145
<arg>-incremental</arg>
146146
</codeserverArgs>
147147
<moduleName>${gwt.module}</moduleName>

0 commit comments

Comments
 (0)