Only query server interfaces when cluster_state is not absent

Author: Bharat Kunwar

tasks/main.yml

@@ -41,31 +41,32 @@
         cluster_group: "{{ stack_output.stdout | from_json }}"
   when: cluster_state == 'query'
 
-- name: Extract server ids from cluster group output
-  set_fact:
-    cluster_servers: "{{ cluster_group.output_value | json_query('[*].nodes[*].id') | flatten }}"
-    cluster_interfaces: "{{ cluster_net | map(attribute='net') | list }}"
-
-- name: Attach interfaces to servers
-  os_server_interface:
-    auth_type: "{{ cluster_auth_type or omit }}"
-    auth: "{{ cluster_auth or omit }}"
-    cloud: "{{ cluster_cloud or omit }}"
-    state: "{{ cluster_state }}"
-    server_id: "{{ item }}"
-    interfaces: "{{ cluster_interfaces }}"
-  with_items: "{{ cluster_servers }}"
-  register: openstack_server_interfaces
-
-- set_fact:
-    cluster_server_interfaces: "{{ dict(cluster_servers | zip(openstack_server_interfaces.results)) }}"
-
 - name: Reset the python interpreter
   set_fact:
     ansible_python_interpreter: "{{ old_python_interpreter }}"
   when: cluster_venv != None
 
 - block:
+    - name: Extract server ids from cluster group output
+      set_fact:
+        cluster_servers: "{{ cluster_group.output_value | json_query('[*].nodes[*].id') | flatten }}"
+        cluster_interfaces: "{{ cluster_net | map(attribute='net') | list }}"
+
+    - name: Attach interfaces to servers
+      os_server_interface:
+        auth_type: "{{ cluster_auth_type or omit }}"
+        auth: "{{ cluster_auth or omit }}"
+        cloud: "{{ cluster_cloud or omit }}"
+        state: "{{ cluster_state }}"
+        server_id: "{{ item }}"
+        interfaces: "{{ cluster_interfaces }}"
+      with_items: "{{ cluster_servers }}"
+      register: openstack_server_interfaces
+
+    - name: Convert list of interfaces to a dictionary for easy lookup in inventory templating step
+      set_fact:
+        cluster_server_interfaces: "{{ dict(cluster_servers | zip(openstack_server_interfaces.results)) }}"
+
     - name: Extract node objects
       set_fact:
         cluster_nodes: "{{ cluster_group.output_value | sum(attribute='nodes', start=[]) }}"