Skip to content

Commit 8f338e0

Browse files
ssbarneaaakarshg
authored andcommitted
Fix python3.7 import errors and made job voting
Python3.7 finally removed relative imports so we adopt the correct syntax and also making py37 job voting to avoid regressions. Change-Id: I16e01344e8ae1c732c31264c50d6dd57143ea799
1 parent 7c3aed6 commit 8f338e0

File tree

7 files changed

+40
-37
lines changed

7 files changed

+40
-37
lines changed

.zuul.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
- project:
33
templates:
44
- docs-on-readthedocs
5-
- openstack-python37-jobs-nonvoting
5+
- openstack-python37-jobs
66
- openstack-python36-jobs
77
vars:
88
rtd_webhook_id: '51626'

browbeat/perfkit.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
import subprocess
2020
import time
2121

22-
import elastic
23-
import grafana
24-
from path import get_overcloudrc
25-
from path import get_workload_venv
26-
from path import results_path
27-
import tools
28-
import workloadbase
22+
import browbeat.tools
23+
from browbeat import elastic
24+
from browbeat import grafana
25+
from browbeat import workloadbase
26+
from browbeat.path import get_overcloudrc
27+
from browbeat.path import get_workload_venv
28+
from browbeat.path import results_path
2929

3030
class PerfKit(workloadbase.WorkloadBase):
3131

@@ -34,7 +34,7 @@ def __init__(self, config, result_dir_ts):
3434
self.overcloudrc = get_overcloudrc()
3535
self.config = config
3636
self.result_dir_ts = result_dir_ts
37-
self.tools = tools.Tools(self.config)
37+
self.tools = browbeat.tools.Tools(self.config)
3838
self.grafana = grafana.Grafana(self.config)
3939
self.elastic = elastic.Elastic(self.config, self.__class__.__name__.lower())
4040

browbeat/rally.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,20 @@
2020
import shutil
2121
import time
2222

23-
import elastic
24-
import grafana
25-
from path import get_workload_venv
26-
from path import results_path
27-
import workloadbase
28-
import tools
29-
23+
import browbeat.tools
24+
from browbeat import elastic
25+
from browbeat import grafana
26+
from browbeat import workloadbase
27+
from browbeat.path import get_workload_venv
28+
from browbeat.path import results_path
3029

3130
class Rally(workloadbase.WorkloadBase):
3231

3332
def __init__(self, config, result_dir_ts):
3433
self.logger = logging.getLogger('browbeat.rally')
3534
self.config = config
3635
self.result_dir_ts = result_dir_ts
37-
self.tools = tools.Tools(self.config)
36+
self.tools = browbeat.tools.Tools(self.config)
3837
self.grafana = grafana.Grafana(self.config)
3938
self.elastic = elastic.Elastic(self.config, self.__class__.__name__.lower())
4039

browbeat/shaker.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
import uuid
2020
import yaml
2121

22-
import elastic
23-
import grafana
24-
from path import get_overcloudrc
25-
from path import get_workload_venv
26-
from path import results_path
27-
import workloadbase
28-
import tools
22+
import browbeat.tools
23+
from browbeat import elastic
24+
from browbeat import grafana
25+
from browbeat import workloadbase
26+
from browbeat.path import get_overcloudrc
27+
from browbeat.path import get_workload_venv
28+
from browbeat.path import results_path
2929

3030

3131
class Shaker(workloadbase.WorkloadBase):
@@ -35,7 +35,7 @@ def __init__(self, config, result_dir_ts):
3535
self.overcloudrc = get_overcloudrc()
3636
self.config = config
3737
self.result_dir_ts = result_dir_ts
38-
self.tools = tools.Tools(self.config)
38+
self.tools = browbeat.tools.Tools(self.config)
3939
self.grafana = grafana.Grafana(self.config)
4040
self.elastic = elastic.Elastic(self.config, self.__class__.__name__.lower())
4141

browbeat/tools.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import re
1717
import subprocess
1818

19-
import perfkit
20-
import rally
21-
import shaker
22-
import yoda
19+
from browbeat import perfkit
20+
from browbeat import rally
21+
from browbeat import shaker
22+
from browbeat import yoda
2323

2424

2525
class Tools(object):
@@ -51,7 +51,7 @@ def run_cmd(self, cmd):
5151
stderr=subprocess.PIPE)
5252
stdout, stderr = process.communicate()
5353
output_dict = {}
54-
output_dict['stdout'] = stdout.strip()
54+
output_dict['stdout'] = stdout.strip().decode()
5555
output_dict['stderr'] = stderr.strip()
5656
output_dict['rc'] = process.returncode
5757
if process.returncode > 0:

browbeat/yoda.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@
2828
ostag = None
2929
import requests
3030

31-
import elastic
32-
import grafana
33-
from path import results_path
34-
import workloadbase
35-
import tools
31+
import browbeat.tools
32+
from browbeat import elastic
33+
from browbeat import grafana
34+
from browbeat import workloadbase
35+
from browbeat.path import results_path
3636

3737

3838
class Yoda(workloadbase.WorkloadBase):
@@ -41,7 +41,7 @@ def __init__(self, config, result_dir_ts):
4141
self.logger = logging.getLogger('browbeat.yoda')
4242
self.config = config
4343
self.result_dir_ts = result_dir_ts
44-
self.tools = tools.Tools(self.config)
44+
self.tools = browbeat.tools.Tools(self.config)
4545
self.grafana = grafana.Grafana(self.config)
4646
self.elastic = elastic.Elastic(self.config, self.__class__.__name__.lower())
4747
self.error_count = 0

tox.ini

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tox]
22
minversion = 2.0
3-
envlist = py27,py35,py36,linters,dist,insights
3+
envlist = py27,py35,py36,py37,linters,dist,insights
44
skipsdist = True
55

66
[testenv]
@@ -62,6 +62,10 @@ commands = pytest {posargs}
6262
basepython = python3.6
6363
commands = pytest {posargs}
6464

65+
[testenv:py37]
66+
basepython = python3.7
67+
commands = pytest {posargs}
68+
6569
[testenv:cover]
6670
commands = python setup.py test --coverage --testr-args={posargs}
6771

0 commit comments

Comments
 (0)