Skip to content

Commit fbc6af2

Browse files
committed
Changed from Canvas Widget to Canvas element
1 parent bfcfa2f commit fbc6af2

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

processingjs-gwt/src/main/java/com/github/timeu/gwtlibs/processingjsgwt/client/Processing.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.google.gwt.canvas.client.Canvas;
44
import com.google.gwt.core.client.ScriptInjector;
55
import com.google.gwt.core.shared.GWT;
6+
import com.google.gwt.dom.client.Document;
67
import com.google.gwt.http.client.Request;
78
import com.google.gwt.http.client.RequestBuilder;
89
import com.google.gwt.http.client.RequestCallback;
@@ -33,15 +34,13 @@ interface ProcessingClientBundle extends ClientBundle {
3334

3435
protected I pInstance;
3536
protected boolean isLoaded = false;
36-
protected final Canvas canvas;
3737

3838
/**
3939
* Creates a Processing widget
4040
*/
4141
public Processing() {
4242
injectScript();
43-
canvas = Canvas.createIfSupported();
44-
setElement(canvas.getElement());
43+
setElement(Document.get().createCanvasElement());
4544
}
4645

4746
/**
@@ -134,15 +133,7 @@ protected final native I init(String programm,Element elem) /*-{
134133
}-*/;
135134

136135

137-
/**
138-
* Provides access to the Canvas widget
139-
*
140-
* @return the {@link Canvas} widget
141-
*/
142-
public Canvas getCanvas() {
143-
return canvas;
144-
}
145-
136+
146137
private void injectScript() {
147138
if (!isInjected()) {
148139
ScriptInjector.fromString(ProcessingClientBundle.INSTANCE.processingjs().getText()).setWindow(ScriptInjector.TOP_WINDOW).inject();

processingjs-gwt/src/test/java/com/github/timeu/gwtlibs/processingjsgwt/client/ProcessingTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public String getModuleName() {
4242

4343
public void testCreateAndCheckCanvasExists() {
4444
Processing<MyProcessingInstance> widget = new Processing<>();
45-
assertNotNull(widget.getCanvas());
4645
assertEquals(widget.isLoaded(),false);
4746
assertEquals(widget.isInjected(),true);
4847
assertNull(widget.getInstance());
@@ -66,7 +65,6 @@ private void checkLoadedWdiget(Processing<MyProcessingInstance> widget) {
6665
assertEquals(widget.isInjected(),true);
6766
assertEquals(widget.isLoaded(),true);
6867
assertNotNull("Processing instance is null",widget.getInstance());
69-
assertNotNull("Canvas is null", widget.getCanvas());
7068
}
7169

7270
}

0 commit comments

Comments
 (0)