Switch off nova metadata api on the undercloud

All known consumers of boot data (os-collect-config, etc) have a
preference for using config-drive as the data source.

The last known consumer was novajoin, but that switched to preferring
config-drive early in the Stein development cycle[1] so it should now
be safe to switch off the nova metadata API service.

[1] https://review.opendev.org/#/c/607492/
Blueprint: nova-less-deploy

Change-Id: If35aec24f446769fca7897c2126fb6657454f073

Author: steveb

environments/undercloud.yaml

@@ -14,7 +14,6 @@ resource_registry:
   OS::TripleO::Network::Ports::ExternalVipPort: ../network/ports/external_from_pool.yaml
 
   OS::TripleO::Services::ComputeNeutronOvsAgent: ../deployment/neutron/neutron-ovs-agent-container-puppet.yaml
-  OS::TripleO::Services::NeutronMetadataAgent: ../deployment/neutron/neutron-metadata-container-puppet.yaml
   OS::TripleO::Services::NeutronOvsAgent: ../deployment/neutron/neutron-ovs-agent-container-puppet.yaml
   OS::TripleO::Services::NeutronDhcpAgent: ../deployment/neutron/neutron-dhcp-container-puppet.yaml
   OS::TripleO::Services::NeutronL3Agent: ../deployment/neutron/neutron-l3-container-puppet.yaml
@@ -39,6 +38,8 @@ resource_registry:
   OS::TripleO::Services::CinderApi: OS::Heat::None
   OS::TripleO::Services::CinderScheduler: OS::Heat::None
   OS::TripleO::Services::CinderVolume: OS::Heat::None
+  OS::TripleO::Services::NovaMetadata: OS::Heat::None
+  OS::TripleO::Services::NeutronMetadataAgent: OS::Heat::None
 
   # Services we don't ever want configured. See LP#1824030
   OS::TripleO::Services::Pacemaker: OS::Heat::None
@@ -191,8 +192,7 @@ parameter_defaults:
   MySQLServerOptions:
     mysqld:
       connect_timeout: 60
-  NeutronMetadataProxySharedSecret: ''
-  MetadataNATRule: true
+  MetadataNATRule: false
   # TODO(emilien) Remove when Keepalived 2.0.6 is out
   # https://bugs.launchpad.net/tripleo/+bug/1791238
   KeepalivedRestart: true

roles/Undercloud.yaml

@@ -70,7 +70,6 @@
     - OS::TripleO::Services::NovaApi
     - OS::TripleO::Services::NovaConductor
     - OS::TripleO::Services::NovaIronic
-    - OS::TripleO::Services::NovaMetadata
     - OS::TripleO::Services::NovaScheduler
     - OS::TripleO::Services::Novajoin
     - OS::TripleO::Services::OpenStackClients

roles_data_undercloud.yaml

@@ -73,7 +73,6 @@
     - OS::TripleO::Services::NovaApi
     - OS::TripleO::Services::NovaConductor
     - OS::TripleO::Services::NovaIronic
-    - OS::TripleO::Services::NovaMetadata
     - OS::TripleO::Services::NovaScheduler
     - OS::TripleO::Services::Novajoin
     - OS::TripleO::Services::OpenStackClients