Skip to content

Don't trim when onType-reformatting the document #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

pbwolf
Copy link
Contributor

@pbwolf pbwolf commented Apr 12, 2025

What has changed?

One must be able to add a newline to the end of a document, but doing so triggers format-on-type, which therefore should not briskly remove the new newline.

Format-as-you-type reformats the entire document under some circumstances. In that case it did not check whether the reason for reformatting was format-as-you-type. The change reduces trimming in that case.

Fixes #2778

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

One must be able to add a newline to the end of a document,
but doing so triggers format-on-type, which therefore
should not briskly remove the new newline.
Copy link

netlify bot commented Apr 12, 2025

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit a22885c
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/67fa7583aa4281000887b62b
😎 Deploy Preview https://deploy-preview-2779--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit 6d5f9f4 into BetterThanTomorrow:dev Apr 12, 2025
5 checks passed
@PEZ
Copy link
Collaborator

PEZ commented Apr 12, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants