-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Consistent naming for utils and utilising shared folder #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
salmanmkc
wants to merge
16
commits into
actions:main
Choose a base branch
from
salmanmkc:salmanmkc/5-clean-up-util-approach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Consistent naming for utils and utilising shared folder #1999
salmanmkc
wants to merge
16
commits into
actions:main
from
salmanmkc:salmanmkc/5-clean-up-util-approach
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nmkc/toolkit into salmanmkc/5-clean-up-util-approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for doing this is to standardise the approach for having shared utils or the naming across the files.
This pull request includes several changes to update import paths across multiple test and source files. The primary change is renaming the import path from
util
toutils
in various files within thepackages/artifact
andpackages/cache
directories.Changes to utility imports:
Updated import statements to use
utils
instead ofutil
in multiple test files:packages/artifact/__tests__/delete-artifacts.test.ts
packages/artifact/__tests__/download-artifact.test.ts
packages/artifact/__tests__/get-artifact.test.ts
packages/artifact/__tests__/list-artifacts.test.ts
packages/artifact/__tests__/upload-artifact.test.ts
packages/artifact/__tests__/utils.test.ts
Updated import statements to use
utils
instead ofutil
in source files:packages/artifact/src/internal/delete/delete-artifact.ts
packages/artifact/src/internal/download/download-artifact.ts
packages/artifact/src/internal/find/get-artifact.ts
packages/artifact/src/internal/find/list-artifacts.ts
packages/artifact/src/internal/shared/artifact-twirp-client.ts
packages/artifact/src/internal/upload/upload-artifact.ts
Changes to cache utilities:
shared/utils
instead ofcacheUtils
in cache-related test files:packages/cache/__tests__/cacheHttpClient.test.ts
packages/cache/__tests__/cacheUtils.test.ts
packages/cache/__tests__/downloadUtils.test.ts
packages/cache/__tests__/requestUtils.test.ts
packages/cache/__tests__/restoreCache.test.ts
[1] [2]packages/cache/__tests__/restoreCacheV2.test.ts
[1] [2]packages/cache/__tests__/saveCache.test.ts
[1] [2] [3]