Skip to content

Consistent naming for utils and utilising shared folder #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

salmanmkc
Copy link
Contributor

@salmanmkc salmanmkc commented Mar 19, 2025

Reason for doing this is to standardise the approach for having shared utils or the naming across the files.
This pull request includes several changes to update import paths across multiple test and source files. The primary change is renaming the import path from util to utils in various files within the packages/artifact and packages/cache directories.

Changes to utility imports:

  • Updated import statements to use utils instead of util in multiple test files:

    • packages/artifact/__tests__/delete-artifacts.test.ts
    • packages/artifact/__tests__/download-artifact.test.ts
    • packages/artifact/__tests__/get-artifact.test.ts
    • packages/artifact/__tests__/list-artifacts.test.ts
    • packages/artifact/__tests__/upload-artifact.test.ts
    • packages/artifact/__tests__/utils.test.ts
  • Updated import statements to use utils instead of util in source files:

    • packages/artifact/src/internal/delete/delete-artifact.ts
    • packages/artifact/src/internal/download/download-artifact.ts
    • packages/artifact/src/internal/find/get-artifact.ts
    • packages/artifact/src/internal/find/list-artifacts.ts
    • packages/artifact/src/internal/shared/artifact-twirp-client.ts
    • packages/artifact/src/internal/upload/upload-artifact.ts

Changes to cache utilities:

  • Updated import statements to use shared/utils instead of cacheUtils in cache-related test files:
    • packages/cache/__tests__/cacheHttpClient.test.ts
    • packages/cache/__tests__/cacheUtils.test.ts
    • packages/cache/__tests__/downloadUtils.test.ts
    • packages/cache/__tests__/requestUtils.test.ts
    • packages/cache/__tests__/restoreCache.test.ts [1] [2]
    • packages/cache/__tests__/restoreCacheV2.test.ts [1] [2]
    • packages/cache/__tests__/saveCache.test.ts [1] [2] [3]

@salmanmkc salmanmkc marked this pull request as ready for review March 24, 2025 18:39
@salmanmkc salmanmkc requested review from a team as code owners March 24, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant