Skip to content

feat: add ability to read new file format #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

joseph-sentry
Copy link
Contributor

i'm introducing 2 things here:

  • the ability to read the output of the new ta cache rollups code in
    the new location in GCS
  • the ability to read multiple versions of the new rollup file
    • its probable that the "no version" file never exists in prod GCS
      but i'd like to establish this pattern in the code nonetheless

i also add metrics

@joseph-sentry joseph-sentry requested a review from a team as a code owner March 31, 2025 22:38
Copy link
Contributor

sentry-autofix bot commented Mar 31, 2025

🚨 Sentry detected 5 potential issues in your recent changes 🚨

Lower risk findings
  • Line 105, utils/test_results.py: Incompatible types in assignment (expression has type "Callable[[int, str, int, int | None], DataFrame | None]", variable has type "Callable[[int, str | None, int, int | None], DataFrame | None]")

    • Incompatible types in assignment. old_get_results expects branch to be a string, but get_results can pass None.
  • Line 56, graphql_api/tests/test_test_analytics.py: 'datetime.datetime()' called without a 'tzinfo' argument

    • datetime.datetime() is called without timezone information, which can lead to inconsistent behavior across different environments.
  • Line 107, graphql_api/tests/test_test_analytics.py: 'datetime.datetime.now()' called without a 'tz' argument

    • datetime.datetime.now() is called without timezone information, which can lead to inconsistent behavior across different environments.
  • Line 111, graphql_api/tests/test_test_analytics.py: 'datetime.datetime.now()' called without a 'tz' argument

    • datetime.datetime.now() is called without timezone information, which can lead to inconsistent behavior across different environments.
  • Line 245, utils/test_results.py: 'datetime.date.today()' used

    • datetime.date.today() is used, which is not timezone-aware and can lead to issues with timezones.

Did you find this useful? React with a 👍 or 👎

@joseph-sentry joseph-sentry requested a review from a team April 1, 2025 16:48
image: minio/minio:latest
command: server /export
ports:
- "${MINIO_PORT:-9000}:9000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed recently that shared/worker are conflicting with each other, as they are exposing this port to the host. we don’t need this in order to run tests, so I would just not do this.

@joseph-sentry joseph-sentry force-pushed the joseph/file-format branch 2 times, most recently from 2b2e69b to a5e0d4e Compare April 3, 2025 15:33
@codecov-notifications
Copy link

codecov-notifications bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/test_results.py 79.16% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (c2edbb3) to head (9774f44).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/test_results.py 79.16% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   96.35%   96.32%   -0.03%     
==========================================
  Files         488      488              
  Lines       16919    16968      +49     
==========================================
+ Hits        16302    16345      +43     
- Misses        617      623       +6     
Flag Coverage Δ
unit 96.32% <84.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry requested a review from Swatinem April 4, 2025 15:14
i'm introducing 2 things here:
- the ability to read the output of the new ta cache rollups code in
  the new location in GCS
- the ability to read multiple versions of the new rollup file
    - its probable that the "no version" file never exists in prod GCS
      but i'd like to establish this pattern in the code nonetheless

i also add metrics
i'm introducing 2 things here:
- the ability to read the output of the new ta cache rollups code in
  the new location in GCS
- the ability to read multiple versions of the new rollup file
    - its probable that the "no version" file never exists in prod GCS
      but i'd like to establish this pattern in the code nonetheless

i also add metrics
Copy link
Contributor

@spalmurray spalmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed and trust Arpad. Just codeowner stamping for ya

@spalmurray
Copy link
Contributor

apparently I'm not a member of the team LOL. You are @joseph-sentry can you stamp your own PR 😆

Copy link
Contributor

@JerrySentry JerrySentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joseph-sentry joseph-sentry added this pull request to the merge queue Apr 22, 2025
Merged via the queue into main with commit 7090578 Apr 22, 2025
19 of 24 checks passed
@joseph-sentry joseph-sentry deleted the joseph/file-format branch April 22, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants