-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add ability to read new file format #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Sentry detected 5 potential issues in your recent changes 🚨Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
91f65de
to
d84eaab
Compare
d84eaab
to
dba1525
Compare
docker-compose.yml
Outdated
image: minio/minio:latest | ||
command: server /export | ||
ports: | ||
- "${MINIO_PORT:-9000}:9000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed recently that shared/worker are conflicting with each other, as they are exposing this port to the host. we don’t need this in order to run tests, so I would just not do this.
2b2e69b
to
a5e0d4e
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 96.35% 96.32% -0.03%
==========================================
Files 488 488
Lines 16919 16968 +49
==========================================
+ Hits 16302 16345 +43
- Misses 617 623 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a5e0d4e
to
854e334
Compare
i'm introducing 2 things here: - the ability to read the output of the new ta cache rollups code in the new location in GCS - the ability to read multiple versions of the new rollup file - its probable that the "no version" file never exists in prod GCS but i'd like to establish this pattern in the code nonetheless i also add metrics
i'm introducing 2 things here: - the ability to read the output of the new ta cache rollups code in the new location in GCS - the ability to read multiple versions of the new rollup file - its probable that the "no version" file never exists in prod GCS but i'd like to establish this pattern in the code nonetheless i also add metrics
854e334
to
9774f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed and trust Arpad. Just codeowner stamping for ya
apparently I'm not a member of the team LOL. You are @joseph-sentry can you stamp your own PR 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
i'm introducing 2 things here:
the new location in GCS
but i'd like to establish this pattern in the code nonetheless
i also add metrics