Skip to content

Update shared and sentry_sdk #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Update shared and sentry_sdk #1272

merged 3 commits into from
Apr 10, 2025

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Apr 4, 2025

This pulls in an updated version of shared that has more caching, in particular around GitHub calls.

Also updates the sentry_sdk, and configures it to automatically flag redis calls related to caching.


Updating the Sentry SDK for some reasons I don’t understand required me to mess with the django signals and shelter integration. On the positive side, we had shelter enabled for tests, which resulted in a shitton of errors being logged to the console, as it was constantly firing requests into nowhere in the background.
This change should thus reduce log spam when running tests, as well as speeding those up a bit.

I can also extract that change as its own PR if necessary.

This pulls in an updated version of shared that has more caching, in particular around GitHub calls.

Also updates the `sentry_sdk`, and configures it to automatically flag redis calls related to caching.
@Swatinem Swatinem requested a review from a team April 4, 2025 10:17
@Swatinem Swatinem self-assigned this Apr 4, 2025
Copy link
Contributor

sentry-autofix bot commented Apr 4, 2025

✅ Sentry found no issues in your recent changes ✅

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (382f278) to head (005f2f8).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
+ Coverage   96.32%   96.36%   +0.03%     
==========================================
  Files         487      487              
  Lines       16907    16897      -10     
==========================================
- Hits        16285    16282       -3     
+ Misses        622      615       -7     
Flag Coverage Δ
unit 96.36% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@Swatinem Swatinem added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 1b1e320 Apr 10, 2025
23 of 24 checks passed
@Swatinem Swatinem deleted the swatinem/update-shared branch April 10, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants