Remove the delete_timeseries part of Repo deletion
#1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 488 488
Lines 16930 16926 -4
=======================================
- Hits 16312 16309 -3
+ Misses 618 617 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nicholas-codecov
approved these changes
Apr 10, 2025
A while back in codecov/worker#1091, I added the timeseries cleanup/deletion to the more general `Repository` cleanup logic. With that change, it is not necessary anymore to call a separate task to delete all the associated timeseries data.
Swatinem
force-pushed
the
swatinem/rm-deletetimeseries
branch
from
a2680c2 to
450c7d2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back in codecov/worker#1091, I added the timeseries cleanup/deletion to the more general
Repositorycleanup logic.With that change, it is not necessary anymore to call a separate task to delete all the associated timeseries data.
However, there is still a
delete_component_measurementscall, which triggers deletion for a more focussed subset of timeseries data. So the task code itself still lives on for another day.