Skip to content

Consolidate duplicated is_admin_on_provider fn #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Apr 9, 2025

No description provided.

@Swatinem Swatinem requested a review from a team April 9, 2025 12:23
@Swatinem Swatinem self-assigned this Apr 9, 2025
Copy link
Contributor

sentry-autofix bot commented Apr 9, 2025

✅ Sentry found no issues in your recent changes ✅

@Swatinem Swatinem force-pushed the swatinem/dedup-isadmin branch 2 times, most recently from ac91c1c to d393a41 Compare April 10, 2025 07:28
@Swatinem Swatinem force-pushed the swatinem/dedup-isadmin branch from d393a41 to 69a5f33 Compare April 10, 2025 09:09
@codecov-notifications
Copy link

codecov-notifications bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (1b1e320) to head (69a5f33).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   96.36%   96.34%   -0.02%     
==========================================
  Files         487      488       +1     
  Lines       16897    16923      +26     
==========================================
+ Hits        16282    16305      +23     
- Misses        615      618       +3     
Flag Coverage Δ
unit 96.34% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem enabled auto-merge April 10, 2025 10:50
@Swatinem Swatinem disabled auto-merge April 10, 2025 12:30
@Swatinem Swatinem enabled auto-merge April 10, 2025 12:30
@Swatinem Swatinem added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit e493767 Apr 10, 2025
21 of 24 checks passed
@Swatinem Swatinem deleted the swatinem/dedup-isadmin branch April 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants